Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add noDefaultLabels config option to the globalOptions type #1971

Merged

Conversation

laughedelic
Copy link
Contributor

What Changed

Follow up on #1966. Adding the new flag to the globalOptions type descriptor.

Why

See #1955 (comment).

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

@adierkens adierkens added the patch Increment the patch version when merged label Apr 29, 2021
@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #1971 (c4fd159) into main (7fabf23) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1971   +/-   ##
=======================================
  Coverage   80.18%   80.18%           
=======================================
  Files          65       65           
  Lines        5300     5300           
  Branches     1237     1237           
=======================================
  Hits         4250     4250           
  Misses        697      697           
  Partials      353      353           
Impacted Files Coverage Δ
packages/core/src/types.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1fcc83...c4fd159. Read the comment docs.

@laughedelic laughedelic marked this pull request as ready for review April 29, 2021 23:11
@reintroducing
Copy link

@adierkens @hipstersmoothie would it be possible to get this released? i can try it out right away.

This does bring up a good point though and I have a suggestion for you based on how we do canaries. Everytime a PR is open, we have a github action to automatically do a canary release and it updates the PR description with the Canary info. It would make it a lot easier for people to test changes like this by throwing the Canary release into their script and trying it out without you having to publish a new version unnecessarily that may be broken (like the last one). Just something to consider.

@hipstersmoothie hipstersmoothie merged commit 66b34a1 into intuit:main May 3, 2021
@hipstersmoothie
Copy link
Collaborator

Sorry for the delay! merged now

@adierkens
Copy link
Collaborator

🚀 PR was released in v10.26.1 🚀

@adierkens adierkens added the released This issue/pull request has been released. label May 3, 2021
@laughedelic laughedelic deleted the fix/no-default-labels-type branch May 3, 2021 16:35
@reintroducing
Copy link

@hipstersmoothie No worries, this worked, thank you and @laughedelic!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants