Unapproved PR builds now override beta builds in Semver ranges

[rconnamacher]

Describe the bug

Pull request #1997 reverted an earlier intentional change to prevent PR builds from overriding beta releases. With this latest change, PR builds -- opened by anyone at all with no code review or approval required -- will be automatically deployed to projects matching prerelease version ranges like >=1.0.0-beta.1.

Semver matches prerelease tags in alphabetical order, so "canary" is after "alpha" and "beta". If a PR build is ever to be allowed, it must always go before approved branch builds like beta and alpha.

[hipstersmoothie]

@10hendersonm what was your reasoning for removing the double dash? Sorry I futzed this up @rconnamacher

[10hendersonm]

It seemed out of place :(

We went from 9.54.0 to latest and our regex for finding canary versions broke. I saw in the code that the dash was stripped off in some places but not in others within the npm plugin's canary hook, so it seemed unevenly applied.

We have since updated our regex to accept both because I hadn't anticipated such a quick merge, so if this is breaking for others it is no longer breaking for me to be in either situation.

[adierkens]

🚀 Issue was released in v10.29.3 🚀

[rconnamacher]

Thanks for fixing this! There probably should be a comment on that line so people know why the double-hyphens are there -- to ensure it sorts before "alpha" alphabetically