New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Microsoft Teams - Invalid Message Formatting #2020
Comments
I'm not a user of Microsoft teams myself. If you find something that can be improved feel free to make a PR! |
@vincentbriglia: We're trying to understand why the I would be happy to make the necessary changes myself, but I would like to understand why Just to make sure that |
@mathieubergeron Thank you for bring this up, it's definitely a sight for sore eyes in our Teams npm publish reporting channel :) I was going to circle back on this after my PTO in two weeks because I've had enough looking at it but looks like you've already found the issue. It would be great if we can get a new version published that fixes this. I know you're waiting on an answer but honestly, it's completely unusable as it is so I'd favor a "get this out now and answer questions later" approach if possible. @hipstersmoothie thoughts? |
@mathieubergeron @reintroducing i would have never pushed anything that didn't work at the time, there is no way of double checking now, but it worked for 1 commit and immediately after we got this garbled content also - we just haven't prioritized the work on our end. Feel free to create a PR, @hipstersmoothie will pull it in without doubt. |
@mathieubergeron @reintroducing @vincentbriglia I can confirm that removing |
Describe the bug
Getting incorrect formatted message using MS Teams plugin. Text looks like escaped version with special characters like
\n
. For example:To Reproduce
Enable
microsoft-teams
plugin and executeauto shipit
Expected behavior
Message in MS Teams channel looks closed to formatted version from generated
CHANGELOG.md
. E.g. there are URLs, multiline formatting and basic emoji icons.Screenshots
Environment information:
Additional context
Message in MS Teams channel looks like escaped/serialized markdown version. I performed two tests:
CHANGELOG.md
file, perform JSON string escaping and send it it via Postman using MS Teams Web hook URL. As result got well formatted text (only few icons were missed, but this is MS Teams related issue).Based on this, I conclude that MS Teams API works fine but issue is with formatting on sender side.
For example what I did manually and hat works fine:
source text from
CHANGELOG.md
:escaped string:
Request for MS Teams WEB Hook:
May be somehow related to
sanitizeMarkdown()
function inside https://github.com/intuit/auto/blob/main/plugins/microsoft-teams/src/index.ts and #1914 changes.The text was updated successfully, but these errors were encountered: