Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conventional commits releaseType calculation to include all conventionally committed commits in PR #1723

Merged
merged 1 commit into from Mar 26, 2021

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Jan 15, 2021

What Changed

Fix various conventional commit issues

Why

closes #1719
closes #1910

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major
📦 Published PR as canary version: under canary scope @auto-canary@10.23.0--canary.1723.23574.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@10.23.0--canary.1723.23574.0
npm install @auto-canary/auto@10.23.0--canary.1723.23574.0
npm install @auto-canary/core@10.23.0--canary.1723.23574.0
npm install @auto-canary/package-json-utils@10.23.0--canary.1723.23574.0
npm install @auto-canary/all-contributors@10.23.0--canary.1723.23574.0
npm install @auto-canary/brew@10.23.0--canary.1723.23574.0
npm install @auto-canary/chrome@10.23.0--canary.1723.23574.0
npm install @auto-canary/cocoapods@10.23.0--canary.1723.23574.0
npm install @auto-canary/conventional-commits@10.23.0--canary.1723.23574.0
npm install @auto-canary/crates@10.23.0--canary.1723.23574.0
npm install @auto-canary/docker@10.23.0--canary.1723.23574.0
npm install @auto-canary/exec@10.23.0--canary.1723.23574.0
npm install @auto-canary/first-time-contributor@10.23.0--canary.1723.23574.0
npm install @auto-canary/gem@10.23.0--canary.1723.23574.0
npm install @auto-canary/gh-pages@10.23.0--canary.1723.23574.0
npm install @auto-canary/git-tag@10.23.0--canary.1723.23574.0
npm install @auto-canary/gradle@10.23.0--canary.1723.23574.0
npm install @auto-canary/jira@10.23.0--canary.1723.23574.0
npm install @auto-canary/magic-zero@10.23.0--canary.1723.23574.0
npm install @auto-canary/maven@10.23.0--canary.1723.23574.0
npm install @auto-canary/microsoft-teams@10.23.0--canary.1723.23574.0
npm install @auto-canary/npm@10.23.0--canary.1723.23574.0
npm install @auto-canary/omit-commits@10.23.0--canary.1723.23574.0
npm install @auto-canary/omit-release-notes@10.23.0--canary.1723.23574.0
npm install @auto-canary/pr-body-labels@10.23.0--canary.1723.23574.0
npm install @auto-canary/released@10.23.0--canary.1723.23574.0
npm install @auto-canary/s3@10.23.0--canary.1723.23574.0
npm install @auto-canary/slack@10.23.0--canary.1723.23574.0
npm install @auto-canary/twitter@10.23.0--canary.1723.23574.0
npm install @auto-canary/upload-assets@10.23.0--canary.1723.23574.0
npm install @auto-canary/vscode@10.23.0--canary.1723.23574.0
# or 
yarn add @auto-canary/bot-list@10.23.0--canary.1723.23574.0
yarn add @auto-canary/auto@10.23.0--canary.1723.23574.0
yarn add @auto-canary/core@10.23.0--canary.1723.23574.0
yarn add @auto-canary/package-json-utils@10.23.0--canary.1723.23574.0
yarn add @auto-canary/all-contributors@10.23.0--canary.1723.23574.0
yarn add @auto-canary/brew@10.23.0--canary.1723.23574.0
yarn add @auto-canary/chrome@10.23.0--canary.1723.23574.0
yarn add @auto-canary/cocoapods@10.23.0--canary.1723.23574.0
yarn add @auto-canary/conventional-commits@10.23.0--canary.1723.23574.0
yarn add @auto-canary/crates@10.23.0--canary.1723.23574.0
yarn add @auto-canary/docker@10.23.0--canary.1723.23574.0
yarn add @auto-canary/exec@10.23.0--canary.1723.23574.0
yarn add @auto-canary/first-time-contributor@10.23.0--canary.1723.23574.0
yarn add @auto-canary/gem@10.23.0--canary.1723.23574.0
yarn add @auto-canary/gh-pages@10.23.0--canary.1723.23574.0
yarn add @auto-canary/git-tag@10.23.0--canary.1723.23574.0
yarn add @auto-canary/gradle@10.23.0--canary.1723.23574.0
yarn add @auto-canary/jira@10.23.0--canary.1723.23574.0
yarn add @auto-canary/magic-zero@10.23.0--canary.1723.23574.0
yarn add @auto-canary/maven@10.23.0--canary.1723.23574.0
yarn add @auto-canary/microsoft-teams@10.23.0--canary.1723.23574.0
yarn add @auto-canary/npm@10.23.0--canary.1723.23574.0
yarn add @auto-canary/omit-commits@10.23.0--canary.1723.23574.0
yarn add @auto-canary/omit-release-notes@10.23.0--canary.1723.23574.0
yarn add @auto-canary/pr-body-labels@10.23.0--canary.1723.23574.0
yarn add @auto-canary/released@10.23.0--canary.1723.23574.0
yarn add @auto-canary/s3@10.23.0--canary.1723.23574.0
yarn add @auto-canary/slack@10.23.0--canary.1723.23574.0
yarn add @auto-canary/twitter@10.23.0--canary.1723.23574.0
yarn add @auto-canary/upload-assets@10.23.0--canary.1723.23574.0
yarn add @auto-canary/vscode@10.23.0--canary.1723.23574.0

🐤 Download canary assets:

auto-linux--canary.1723.23574.gz
auto-macos--canary.1723.23574.gz
auto-win.exe--canary.1723.23574.gz

@adierkens adierkens added the minor Increment the minor version when merged label Jan 15, 2021
@codecov
Copy link

codecov bot commented Jan 15, 2021

Codecov Report

Merging #1723 (26b2c89) into main (93df8af) will increase coverage by 0.01%.
The diff coverage is 80.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1723      +/-   ##
==========================================
+ Coverage   80.13%   80.14%   +0.01%     
==========================================
  Files          65       65              
  Lines        5225     5239      +14     
  Branches     1221     1226       +5     
==========================================
+ Hits         4187     4199      +12     
- Misses        692      693       +1     
- Partials      346      347       +1     
Impacted Files Coverage Δ
plugins/conventional-commits/src/index.ts 77.41% <80.95%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93df8af...26b2c89. Read the comment docs.

Base automatically changed from master to main January 20, 2021 19:54
@hipstersmoothie hipstersmoothie changed the title fix conventional commits version calcuation and include all conventionally committed commits in changelog Fix conventional commits releaseType calculation to include all conventionally committed commits in PR Mar 26, 2021
@hipstersmoothie hipstersmoothie merged commit f25f2d6 into main Mar 26, 2021
@hipstersmoothie hipstersmoothie deleted the conv branch March 26, 2021 21:19
@adierkens
Copy link
Collaborator

🚀 PR was released in v10.23.0 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
2 participants