Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When calculating "next" lastTag, fallback to latest tag in baseBranch before first commit #1791

Merged
merged 1 commit into from Feb 11, 2021

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Feb 11, 2021

What Changed

see title

Why

Falling back to the first commit includes too many commits, the last tag in baseBranch is a better starting point if it exists.

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

🐤 Download canary assets:

auto-linux-canary.1791.21987.gz
auto-macos-canary.1791.21987.gz
auto-win.exe-canary.1791.21987.gz

📦 Published PR as canary version: under canary scope @auto-canary@10.16.1-canary.1791.21987.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@10.16.1-canary.1791.21987.0
npm install @auto-canary/auto@10.16.1-canary.1791.21987.0
npm install @auto-canary/core@10.16.1-canary.1791.21987.0
npm install @auto-canary/package-json-utils@10.16.1-canary.1791.21987.0
npm install @auto-canary/all-contributors@10.16.1-canary.1791.21987.0
npm install @auto-canary/brew@10.16.1-canary.1791.21987.0
npm install @auto-canary/chrome@10.16.1-canary.1791.21987.0
npm install @auto-canary/cocoapods@10.16.1-canary.1791.21987.0
npm install @auto-canary/conventional-commits@10.16.1-canary.1791.21987.0
npm install @auto-canary/crates@10.16.1-canary.1791.21987.0
npm install @auto-canary/docker@10.16.1-canary.1791.21987.0
npm install @auto-canary/exec@10.16.1-canary.1791.21987.0
npm install @auto-canary/first-time-contributor@10.16.1-canary.1791.21987.0
npm install @auto-canary/gem@10.16.1-canary.1791.21987.0
npm install @auto-canary/gh-pages@10.16.1-canary.1791.21987.0
npm install @auto-canary/git-tag@10.16.1-canary.1791.21987.0
npm install @auto-canary/gradle@10.16.1-canary.1791.21987.0
npm install @auto-canary/jira@10.16.1-canary.1791.21987.0
npm install @auto-canary/magic-zero@10.16.1-canary.1791.21987.0
npm install @auto-canary/maven@10.16.1-canary.1791.21987.0
npm install @auto-canary/microsoft-teams@10.16.1-canary.1791.21987.0
npm install @auto-canary/npm@10.16.1-canary.1791.21987.0
npm install @auto-canary/omit-commits@10.16.1-canary.1791.21987.0
npm install @auto-canary/omit-release-notes@10.16.1-canary.1791.21987.0
npm install @auto-canary/pr-body-labels@10.16.1-canary.1791.21987.0
npm install @auto-canary/released@10.16.1-canary.1791.21987.0
npm install @auto-canary/s3@10.16.1-canary.1791.21987.0
npm install @auto-canary/slack@10.16.1-canary.1791.21987.0
npm install @auto-canary/twitter@10.16.1-canary.1791.21987.0
npm install @auto-canary/upload-assets@10.16.1-canary.1791.21987.0
npm install @auto-canary/vscode@10.16.1-canary.1791.21987.0
# or 
yarn add @auto-canary/bot-list@10.16.1-canary.1791.21987.0
yarn add @auto-canary/auto@10.16.1-canary.1791.21987.0
yarn add @auto-canary/core@10.16.1-canary.1791.21987.0
yarn add @auto-canary/package-json-utils@10.16.1-canary.1791.21987.0
yarn add @auto-canary/all-contributors@10.16.1-canary.1791.21987.0
yarn add @auto-canary/brew@10.16.1-canary.1791.21987.0
yarn add @auto-canary/chrome@10.16.1-canary.1791.21987.0
yarn add @auto-canary/cocoapods@10.16.1-canary.1791.21987.0
yarn add @auto-canary/conventional-commits@10.16.1-canary.1791.21987.0
yarn add @auto-canary/crates@10.16.1-canary.1791.21987.0
yarn add @auto-canary/docker@10.16.1-canary.1791.21987.0
yarn add @auto-canary/exec@10.16.1-canary.1791.21987.0
yarn add @auto-canary/first-time-contributor@10.16.1-canary.1791.21987.0
yarn add @auto-canary/gem@10.16.1-canary.1791.21987.0
yarn add @auto-canary/gh-pages@10.16.1-canary.1791.21987.0
yarn add @auto-canary/git-tag@10.16.1-canary.1791.21987.0
yarn add @auto-canary/gradle@10.16.1-canary.1791.21987.0
yarn add @auto-canary/jira@10.16.1-canary.1791.21987.0
yarn add @auto-canary/magic-zero@10.16.1-canary.1791.21987.0
yarn add @auto-canary/maven@10.16.1-canary.1791.21987.0
yarn add @auto-canary/microsoft-teams@10.16.1-canary.1791.21987.0
yarn add @auto-canary/npm@10.16.1-canary.1791.21987.0
yarn add @auto-canary/omit-commits@10.16.1-canary.1791.21987.0
yarn add @auto-canary/omit-release-notes@10.16.1-canary.1791.21987.0
yarn add @auto-canary/pr-body-labels@10.16.1-canary.1791.21987.0
yarn add @auto-canary/released@10.16.1-canary.1791.21987.0
yarn add @auto-canary/s3@10.16.1-canary.1791.21987.0
yarn add @auto-canary/slack@10.16.1-canary.1791.21987.0
yarn add @auto-canary/twitter@10.16.1-canary.1791.21987.0
yarn add @auto-canary/upload-assets@10.16.1-canary.1791.21987.0
yarn add @auto-canary/vscode@10.16.1-canary.1791.21987.0

@adierkens adierkens added the patch Increment the patch version when merged label Feb 11, 2021
@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #1791 (41ec65e) into main (9722438) will decrease coverage by 0.01%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1791      +/-   ##
==========================================
- Coverage   80.20%   80.18%   -0.02%     
==========================================
  Files          64       64              
  Lines        4985     4987       +2     
  Branches     1150     1151       +1     
==========================================
+ Hits         3998     3999       +1     
  Misses        671      671              
- Partials      316      317       +1     
Impacted Files Coverage Δ
packages/core/src/auto.ts 77.75% <50.00%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d2fc40...41ec65e. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit 19a8555 into main Feb 11, 2021
@hipstersmoothie hipstersmoothie deleted the base-tag-next branch February 11, 2021 08:11
@adierkens
Copy link
Collaborator

🚀 PR was released in v10.16.1 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Feb 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants