Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typescript require #1885

Merged
merged 1 commit into from Mar 15, 2021
Merged

fix typescript require #1885

merged 1 commit into from Mar 15, 2021

Conversation

hipstersmoothie
Copy link
Collaborator

@hipstersmoothie hipstersmoothie commented Mar 15, 2021

Why

closes #1880

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

🐀 Download canary assets:

auto-linux--canary.1885.23119.gz
auto-macos--canary.1885.23119.gz
auto-win.exe--canary.1885.23119.gz

πŸ“¦ Published PR as canary version: under canary scope @auto-canary@10.20.2--canary.1885.23119.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@10.20.2--canary.1885.23119.0
npm install @auto-canary/auto@10.20.2--canary.1885.23119.0
npm install @auto-canary/core@10.20.2--canary.1885.23119.0
npm install @auto-canary/package-json-utils@10.20.2--canary.1885.23119.0
npm install @auto-canary/all-contributors@10.20.2--canary.1885.23119.0
npm install @auto-canary/brew@10.20.2--canary.1885.23119.0
npm install @auto-canary/chrome@10.20.2--canary.1885.23119.0
npm install @auto-canary/cocoapods@10.20.2--canary.1885.23119.0
npm install @auto-canary/conventional-commits@10.20.2--canary.1885.23119.0
npm install @auto-canary/crates@10.20.2--canary.1885.23119.0
npm install @auto-canary/docker@10.20.2--canary.1885.23119.0
npm install @auto-canary/exec@10.20.2--canary.1885.23119.0
npm install @auto-canary/first-time-contributor@10.20.2--canary.1885.23119.0
npm install @auto-canary/gem@10.20.2--canary.1885.23119.0
npm install @auto-canary/gh-pages@10.20.2--canary.1885.23119.0
npm install @auto-canary/git-tag@10.20.2--canary.1885.23119.0
npm install @auto-canary/gradle@10.20.2--canary.1885.23119.0
npm install @auto-canary/jira@10.20.2--canary.1885.23119.0
npm install @auto-canary/magic-zero@10.20.2--canary.1885.23119.0
npm install @auto-canary/maven@10.20.2--canary.1885.23119.0
npm install @auto-canary/microsoft-teams@10.20.2--canary.1885.23119.0
npm install @auto-canary/npm@10.20.2--canary.1885.23119.0
npm install @auto-canary/omit-commits@10.20.2--canary.1885.23119.0
npm install @auto-canary/omit-release-notes@10.20.2--canary.1885.23119.0
npm install @auto-canary/pr-body-labels@10.20.2--canary.1885.23119.0
npm install @auto-canary/released@10.20.2--canary.1885.23119.0
npm install @auto-canary/s3@10.20.2--canary.1885.23119.0
npm install @auto-canary/slack@10.20.2--canary.1885.23119.0
npm install @auto-canary/twitter@10.20.2--canary.1885.23119.0
npm install @auto-canary/upload-assets@10.20.2--canary.1885.23119.0
npm install @auto-canary/vscode@10.20.2--canary.1885.23119.0
# or 
yarn add @auto-canary/bot-list@10.20.2--canary.1885.23119.0
yarn add @auto-canary/auto@10.20.2--canary.1885.23119.0
yarn add @auto-canary/core@10.20.2--canary.1885.23119.0
yarn add @auto-canary/package-json-utils@10.20.2--canary.1885.23119.0
yarn add @auto-canary/all-contributors@10.20.2--canary.1885.23119.0
yarn add @auto-canary/brew@10.20.2--canary.1885.23119.0
yarn add @auto-canary/chrome@10.20.2--canary.1885.23119.0
yarn add @auto-canary/cocoapods@10.20.2--canary.1885.23119.0
yarn add @auto-canary/conventional-commits@10.20.2--canary.1885.23119.0
yarn add @auto-canary/crates@10.20.2--canary.1885.23119.0
yarn add @auto-canary/docker@10.20.2--canary.1885.23119.0
yarn add @auto-canary/exec@10.20.2--canary.1885.23119.0
yarn add @auto-canary/first-time-contributor@10.20.2--canary.1885.23119.0
yarn add @auto-canary/gem@10.20.2--canary.1885.23119.0
yarn add @auto-canary/gh-pages@10.20.2--canary.1885.23119.0
yarn add @auto-canary/git-tag@10.20.2--canary.1885.23119.0
yarn add @auto-canary/gradle@10.20.2--canary.1885.23119.0
yarn add @auto-canary/jira@10.20.2--canary.1885.23119.0
yarn add @auto-canary/magic-zero@10.20.2--canary.1885.23119.0
yarn add @auto-canary/maven@10.20.2--canary.1885.23119.0
yarn add @auto-canary/microsoft-teams@10.20.2--canary.1885.23119.0
yarn add @auto-canary/npm@10.20.2--canary.1885.23119.0
yarn add @auto-canary/omit-commits@10.20.2--canary.1885.23119.0
yarn add @auto-canary/omit-release-notes@10.20.2--canary.1885.23119.0
yarn add @auto-canary/pr-body-labels@10.20.2--canary.1885.23119.0
yarn add @auto-canary/released@10.20.2--canary.1885.23119.0
yarn add @auto-canary/s3@10.20.2--canary.1885.23119.0
yarn add @auto-canary/slack@10.20.2--canary.1885.23119.0
yarn add @auto-canary/twitter@10.20.2--canary.1885.23119.0
yarn add @auto-canary/upload-assets@10.20.2--canary.1885.23119.0
yarn add @auto-canary/vscode@10.20.2--canary.1885.23119.0

@adierkens adierkens added the patch Increment the patch version when merged label Mar 15, 2021
@codecov
Copy link

codecov bot commented Mar 15, 2021

Codecov Report

Merging #1885 (197e133) into main (157e92f) will increase coverage by 0.00%.
The diff coverage is 66.66%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1885   +/-   ##
=======================================
  Coverage   80.17%   80.17%           
=======================================
  Files          65       65           
  Lines        5164     5165    +1     
  Branches     1209     1209           
=======================================
+ Hits         4140     4141    +1     
  Misses        688      688           
  Partials      336      336           
Impacted Files Coverage Ξ”
packages/core/src/auto.ts 77.81% <66.66%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data
Powered by Codecov. Last update 3635bdc...197e133. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit e686888 into main Mar 15, 2021
@hipstersmoothie hipstersmoothie deleted the buggo branch March 15, 2021 16:08
@adierkens
Copy link
Collaborator

πŸš€ PR was released in v10.20.2 πŸš€

@adierkens adierkens added the released This issue/pull request has been released. label Mar 15, 2021
@reckter
Copy link
Contributor

reckter commented Mar 15, 2021

Thx for the quick fix! πŸš€ πŸ‘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting Cannot find module 'typescript' in CI environments using npx auto
3 participants