Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small gradle plugin enhancement #1896

Merged
merged 1 commit into from Mar 22, 2021
Merged

Small gradle plugin enhancement #1896

merged 1 commit into from Mar 22, 2021

Conversation

brocollie08
Copy link

@brocollie08 brocollie08 commented Mar 22, 2021

Add canary identifier to differentiate canary release version, reverted order of flags in updateGradleVersion to avoid breaking original use cases, added tests

What Changed

Why

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

…ed order of flags to avoid breaking original use cases, added tests
@adierkens adierkens added the patch Increment the patch version when merged label Mar 22, 2021
@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #1896 (a00a3c2) into main (ac38460) will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1896      +/-   ##
==========================================
+ Coverage   80.12%   80.17%   +0.04%     
==========================================
  Files          64       64              
  Lines        5042     5044       +2     
  Branches     1171     1171              
==========================================
+ Hits         4040     4044       +4     
+ Misses        671      670       -1     
+ Partials      331      330       -1     
Impacted Files Coverage Δ
plugins/gradle/src/index.ts 76.85% <100.00%> (+2.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac38460...a00a3c2. Read the comment docs.

@brocollie08 brocollie08 marked this pull request as ready for review March 22, 2021 14:01
@hipstersmoothie hipstersmoothie merged commit de31da8 into intuit:main Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants