Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.ts #1938

Merged
merged 1 commit into from Apr 9, 2021
Merged

Update index.ts #1938

merged 1 commit into from Apr 9, 2021

Conversation

kharrop
Copy link
Contributor

@kharrop kharrop commented Apr 8, 2021

What Changed

Adding "data" as a type, which is an existing all-contributors type. https://allcontributors.org/docs/en/emoji-key

Why

The CI would fail if we used "data" as type, since it was missing from this list.

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

Adding "data" as a type, which is an existing all-contributors type. https://allcontributors.org/docs/en/emoji-key
@adierkens adierkens added the patch Increment the patch version when merged label Apr 8, 2021
@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #1938 (7adf40f) into main (f4f4a86) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1938   +/-   ##
=======================================
  Coverage   80.22%   80.22%           
=======================================
  Files          65       65           
  Lines        5258     5258           
  Branches     1230     1230           
=======================================
  Hits         4218     4218           
  Misses        693      693           
  Partials      347      347           
Impacted Files Coverage Δ
plugins/all-contributors/src/index.ts 83.58% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16d0b6c...7adf40f. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit 9c3c5cf into intuit:main Apr 9, 2021
@adierkens
Copy link
Collaborator

🚀 PR was released in v10.24.2 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Apr 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants