Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove text from non-app authed slack response #1947

Merged
merged 1 commit into from May 11, 2021
Merged

Conversation

adierkens
Copy link
Collaborator

@adierkens adierkens commented Apr 16, 2021

What Changed

Trying to fix #1940. Haven't tested it yet.

Why

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

🐤 Download canary assets:

auto-linux--canary.1947.24201.gz
auto-macos--canary.1947.24201.gz
auto-win.exe--canary.1947.24201.gz

📦 Published PR as canary version: under canary scope @auto-canary@10.27.1--canary.1947.24201.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@10.27.1--canary.1947.24201.0
npm install @auto-canary/auto@10.27.1--canary.1947.24201.0
npm install @auto-canary/core@10.27.1--canary.1947.24201.0
npm install @auto-canary/package-json-utils@10.27.1--canary.1947.24201.0
npm install @auto-canary/all-contributors@10.27.1--canary.1947.24201.0
npm install @auto-canary/brew@10.27.1--canary.1947.24201.0
npm install @auto-canary/chrome@10.27.1--canary.1947.24201.0
npm install @auto-canary/cocoapods@10.27.1--canary.1947.24201.0
npm install @auto-canary/conventional-commits@10.27.1--canary.1947.24201.0
npm install @auto-canary/crates@10.27.1--canary.1947.24201.0
npm install @auto-canary/docker@10.27.1--canary.1947.24201.0
npm install @auto-canary/exec@10.27.1--canary.1947.24201.0
npm install @auto-canary/first-time-contributor@10.27.1--canary.1947.24201.0
npm install @auto-canary/gem@10.27.1--canary.1947.24201.0
npm install @auto-canary/gh-pages@10.27.1--canary.1947.24201.0
npm install @auto-canary/git-tag@10.27.1--canary.1947.24201.0
npm install @auto-canary/gradle@10.27.1--canary.1947.24201.0
npm install @auto-canary/jira@10.27.1--canary.1947.24201.0
npm install @auto-canary/magic-zero@10.27.1--canary.1947.24201.0
npm install @auto-canary/maven@10.27.1--canary.1947.24201.0
npm install @auto-canary/microsoft-teams@10.27.1--canary.1947.24201.0
npm install @auto-canary/npm@10.27.1--canary.1947.24201.0
npm install @auto-canary/omit-commits@10.27.1--canary.1947.24201.0
npm install @auto-canary/omit-release-notes@10.27.1--canary.1947.24201.0
npm install @auto-canary/pr-body-labels@10.27.1--canary.1947.24201.0
npm install @auto-canary/released@10.27.1--canary.1947.24201.0
npm install @auto-canary/s3@10.27.1--canary.1947.24201.0
npm install @auto-canary/slack@10.27.1--canary.1947.24201.0
npm install @auto-canary/twitter@10.27.1--canary.1947.24201.0
npm install @auto-canary/upload-assets@10.27.1--canary.1947.24201.0
npm install @auto-canary/vscode@10.27.1--canary.1947.24201.0
# or 
yarn add @auto-canary/bot-list@10.27.1--canary.1947.24201.0
yarn add @auto-canary/auto@10.27.1--canary.1947.24201.0
yarn add @auto-canary/core@10.27.1--canary.1947.24201.0
yarn add @auto-canary/package-json-utils@10.27.1--canary.1947.24201.0
yarn add @auto-canary/all-contributors@10.27.1--canary.1947.24201.0
yarn add @auto-canary/brew@10.27.1--canary.1947.24201.0
yarn add @auto-canary/chrome@10.27.1--canary.1947.24201.0
yarn add @auto-canary/cocoapods@10.27.1--canary.1947.24201.0
yarn add @auto-canary/conventional-commits@10.27.1--canary.1947.24201.0
yarn add @auto-canary/crates@10.27.1--canary.1947.24201.0
yarn add @auto-canary/docker@10.27.1--canary.1947.24201.0
yarn add @auto-canary/exec@10.27.1--canary.1947.24201.0
yarn add @auto-canary/first-time-contributor@10.27.1--canary.1947.24201.0
yarn add @auto-canary/gem@10.27.1--canary.1947.24201.0
yarn add @auto-canary/gh-pages@10.27.1--canary.1947.24201.0
yarn add @auto-canary/git-tag@10.27.1--canary.1947.24201.0
yarn add @auto-canary/gradle@10.27.1--canary.1947.24201.0
yarn add @auto-canary/jira@10.27.1--canary.1947.24201.0
yarn add @auto-canary/magic-zero@10.27.1--canary.1947.24201.0
yarn add @auto-canary/maven@10.27.1--canary.1947.24201.0
yarn add @auto-canary/microsoft-teams@10.27.1--canary.1947.24201.0
yarn add @auto-canary/npm@10.27.1--canary.1947.24201.0
yarn add @auto-canary/omit-commits@10.27.1--canary.1947.24201.0
yarn add @auto-canary/omit-release-notes@10.27.1--canary.1947.24201.0
yarn add @auto-canary/pr-body-labels@10.27.1--canary.1947.24201.0
yarn add @auto-canary/released@10.27.1--canary.1947.24201.0
yarn add @auto-canary/s3@10.27.1--canary.1947.24201.0
yarn add @auto-canary/slack@10.27.1--canary.1947.24201.0
yarn add @auto-canary/twitter@10.27.1--canary.1947.24201.0
yarn add @auto-canary/upload-assets@10.27.1--canary.1947.24201.0
yarn add @auto-canary/vscode@10.27.1--canary.1947.24201.0

@adierkens adierkens added the patch Increment the patch version when merged label May 11, 2021
@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #1947 (b9e2509) into main (ac603a3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1947   +/-   ##
=======================================
  Coverage   80.27%   80.27%           
=======================================
  Files          65       65           
  Lines        5294     5294           
  Branches     1234     1234           
=======================================
  Hits         4250     4250           
  Misses        694      694           
  Partials      350      350           
Impacted Files Coverage Δ
plugins/slack/src/index.ts 79.26% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 19c05d3...b9e2509. Read the comment docs.

@adierkens adierkens merged commit 5d33773 into main May 11, 2021
@adierkens adierkens deleted the slack-msg-fix branch May 11, 2021 23:24
@adierkens
Copy link
Collaborator Author

🚀 PR was released in v10.27.1 🚀

@adierkens adierkens added the released This issue/pull request has been released. label May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Slack plugin no longer displays PR's or authors
1 participant