Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export CLI API #1967

Merged
merged 1 commit into from Apr 28, 2021
Merged

Conversation

laughedelic
Copy link
Contributor

What Changed

I added exports to the CLI module, to export args parsing functionality and execute method.

Why

See #1964 for the context.

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

@@ -1 +1,3 @@
export { AutoRc } from "@auto-it/core";
export * from "./parse-args";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this ok? Should it have as name part, or it doesn't matter when importing it?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine!

@laughedelic laughedelic changed the title re-export parse-args exports and execute function export CLI API Apr 27, 2021
@adierkens adierkens added the patch Increment the patch version when merged label Apr 27, 2021
@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

❗ No coverage uploaded for pull request base (main@3c51664). Click here to learn what that means.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1967   +/-   ##
=======================================
  Coverage        ?   80.24%           
=======================================
  Files           ?       65           
  Lines           ?     5296           
  Branches        ?     1234           
=======================================
  Hits            ?     4250           
  Misses          ?      696           
  Partials        ?      350           
Impacted Files Coverage Δ
packages/cli/src/index.ts 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c51664...7c469a3. Read the comment docs.

@hipstersmoothie hipstersmoothie merged commit 66f7cbd into intuit:main Apr 28, 2021
@adierkens
Copy link
Collaborator

🚀 PR was released in v10.25.2 🚀

@adierkens adierkens added the released This issue/pull request has been released. label Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants