non-zero exit code if commit is behind #2189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fix has been here for a while. @hipstersmoothie could you take a look? |
|
Sorry for my absence. Will be looking soon! Gotta get ci working first |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
When running auto within our CI pipelines, merges in quick succession can result in the state that the commit to be released is behind the HEAD.
The current behaviour is to "silently" fail with logging a warning and exit code 0 from
auto shipit. The proposed behaviour is a nonzero exit code in these cases where nothing is released.Why
In these cases on our CI the skipped release amounts to a failure that we need to capture and reflect as a failed CI run. When the run of
auto shipitis considered a success, subsequent runs of our CI & CD workflows get out of sync with repository state if the release didn't really happen.Todo:
Change Type
Indicate the type of change your pull request is:
documentationpatchminormajor