Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(docker plugin) fix git tagging command #2256

Merged
merged 1 commit into from Feb 3, 2023
Merged

Conversation

ejhayes
Copy link
Contributor

@ejhayes ejhayes commented Sep 14, 2022

What Changed

Fixes bug introduced with #2232

Why

Previous fix creates git tags with git tag latest -mf "..." which results in an error like this:

Error: Running command 'git' with args [tag, latest, -mf, "Tag release alias: latest (vX.Y.Z)"] failed

This changes the command to use correct syntax for latest, canaries, and prereleases:

git tag -f latest -m "..."

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

@hipstersmoothie hipstersmoothie added the patch Increment the patch version when merged label Sep 14, 2022
@ejhayes
Copy link
Contributor Author

ejhayes commented Sep 15, 2022

This should be working now @hipstersmoothie, not sure why the pr-check job is failing

@ejhayes ejhayes closed this Sep 30, 2022
@ejhayes ejhayes reopened this Sep 30, 2022
@MrHash
Copy link

MrHash commented Dec 2, 2022

Try running the CI again? This issue is affecting me also. My issues is taht the string appears to be not quoted.

Error: Running command 'git' with args [tag, pr-5805, -mf, Tag pull request canary: pr-5805 (1.0.0--canary.5805.28750)] failed

/bin/sh: 1: Syntax error: "(" unexpected

    at ChildProcess.<anonymous> (/home/circleci/repo/node_modules/@auto-it/core/dist/utils/exec-promise.js:58:31)
    at ChildProcess.emit (node:events:513:28)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:291:12)Error
    at Object.execPromise (/home/circleci/repo/node_modules/@auto-it/core/dist/utils/exec-promise.js:15:22)
    at /home/circleci/repo/node_modules/@auto-it/docker/dist/index.js:165:30
    at processTicksAndRejections (node:internal/process/task_queues:96:5)

Exited with code exit status 1

Thanks

@laughedelic
Copy link
Contributor

🆙🙂

@ejhayes
Copy link
Contributor Author

ejhayes commented Jan 26, 2023

Would be great to get this merged in!

@hipstersmoothie hipstersmoothie merged commit f5228e4 into intuit:main Feb 3, 2023
@hipstersmoothie
Copy link
Collaborator

🚀 PR was released in v10.38.0 🚀

@hipstersmoothie hipstersmoothie added the released This issue/pull request has been released. label Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants