Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: init command add .env to .gitignore #2262

Merged
merged 1 commit into from Feb 3, 2023

Conversation

damiencornu
Copy link
Contributor

@damiencornu damiencornu commented Oct 4, 2022

What Changed

Fixes

Why

Before

.env

NPM_TOKEN=not-actual-npm-token
GH_TOKEN=not-actual-github-token

.env

After

.env

NPM_TOKEN=not-actual-npm-token
GH_TOKEN=not-actual-github-token

.gitignore

.env

Todo:

  • Add tests. I did not find tests for init command. Direct me to it if I did not look correctly!
  • Add docs. No need for documentation, fix doesn't change the scope of it

To know if we should add .env to .gitignore we will now read the correct file. It will add it if not already included.

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

Copy link

@ankiiitraj ankiiitraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@hipstersmoothie hipstersmoothie added the patch Increment the patch version when merged label Feb 3, 2023
@hipstersmoothie hipstersmoothie merged commit f33663c into intuit:main Feb 3, 2023
@hipstersmoothie
Copy link
Collaborator

🚀 PR was released in v10.38.0 🚀

@hipstersmoothie hipstersmoothie added the released This issue/pull request has been released. label Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants