Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slack: Update atTarget option to disable tagging messages #2272

Merged
merged 3 commits into from Feb 3, 2023

Conversation

jackw
Copy link
Contributor

@jackw jackw commented Nov 17, 2022

What Changed

Introduced the option to set atTarget option of the slack plugin to false.

Why

To disable pinging entirely when posting a message to a slack channel. I guess we could set it to a slack user that doesn't exist but this feels a little cleaner.

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

🐤 Download canary assets:

auto-linux--canary.2272.26620.gz
auto-macos--canary.2272.26620.gz
auto-win.exe--canary.2272.26620.gz

📦 Published PR as canary version: under canary scope @auto-canary@10.37.7--canary.2272.26620.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@10.37.7--canary.2272.26620.0
npm install @auto-canary/auto@10.37.7--canary.2272.26620.0
npm install @auto-canary/core@10.37.7--canary.2272.26620.0
npm install @auto-canary/package-json-utils@10.37.7--canary.2272.26620.0
npm install @auto-canary/all-contributors@10.37.7--canary.2272.26620.0
npm install @auto-canary/brew@10.37.7--canary.2272.26620.0
npm install @auto-canary/chrome@10.37.7--canary.2272.26620.0
npm install @auto-canary/cocoapods@10.37.7--canary.2272.26620.0
npm install @auto-canary/conventional-commits@10.37.7--canary.2272.26620.0
npm install @auto-canary/crates@10.37.7--canary.2272.26620.0
npm install @auto-canary/docker@10.37.7--canary.2272.26620.0
npm install @auto-canary/exec@10.37.7--canary.2272.26620.0
npm install @auto-canary/first-time-contributor@10.37.7--canary.2272.26620.0
npm install @auto-canary/gem@10.37.7--canary.2272.26620.0
npm install @auto-canary/gh-pages@10.37.7--canary.2272.26620.0
npm install @auto-canary/git-tag@10.37.7--canary.2272.26620.0
npm install @auto-canary/gradle@10.37.7--canary.2272.26620.0
npm install @auto-canary/jira@10.37.7--canary.2272.26620.0
npm install @auto-canary/magic-zero@10.37.7--canary.2272.26620.0
npm install @auto-canary/maven@10.37.7--canary.2272.26620.0
npm install @auto-canary/microsoft-teams@10.37.7--canary.2272.26620.0
npm install @auto-canary/npm@10.37.7--canary.2272.26620.0
npm install @auto-canary/omit-commits@10.37.7--canary.2272.26620.0
npm install @auto-canary/omit-release-notes@10.37.7--canary.2272.26620.0
npm install @auto-canary/pr-body-labels@10.37.7--canary.2272.26620.0
npm install @auto-canary/released@10.37.7--canary.2272.26620.0
npm install @auto-canary/s3@10.37.7--canary.2272.26620.0
npm install @auto-canary/sbt@10.37.7--canary.2272.26620.0
npm install @auto-canary/slack@10.37.7--canary.2272.26620.0
npm install @auto-canary/twitter@10.37.7--canary.2272.26620.0
npm install @auto-canary/upload-assets@10.37.7--canary.2272.26620.0
npm install @auto-canary/version-file@10.37.7--canary.2272.26620.0
npm install @auto-canary/vscode@10.37.7--canary.2272.26620.0
# or 
yarn add @auto-canary/bot-list@10.37.7--canary.2272.26620.0
yarn add @auto-canary/auto@10.37.7--canary.2272.26620.0
yarn add @auto-canary/core@10.37.7--canary.2272.26620.0
yarn add @auto-canary/package-json-utils@10.37.7--canary.2272.26620.0
yarn add @auto-canary/all-contributors@10.37.7--canary.2272.26620.0
yarn add @auto-canary/brew@10.37.7--canary.2272.26620.0
yarn add @auto-canary/chrome@10.37.7--canary.2272.26620.0
yarn add @auto-canary/cocoapods@10.37.7--canary.2272.26620.0
yarn add @auto-canary/conventional-commits@10.37.7--canary.2272.26620.0
yarn add @auto-canary/crates@10.37.7--canary.2272.26620.0
yarn add @auto-canary/docker@10.37.7--canary.2272.26620.0
yarn add @auto-canary/exec@10.37.7--canary.2272.26620.0
yarn add @auto-canary/first-time-contributor@10.37.7--canary.2272.26620.0
yarn add @auto-canary/gem@10.37.7--canary.2272.26620.0
yarn add @auto-canary/gh-pages@10.37.7--canary.2272.26620.0
yarn add @auto-canary/git-tag@10.37.7--canary.2272.26620.0
yarn add @auto-canary/gradle@10.37.7--canary.2272.26620.0
yarn add @auto-canary/jira@10.37.7--canary.2272.26620.0
yarn add @auto-canary/magic-zero@10.37.7--canary.2272.26620.0
yarn add @auto-canary/maven@10.37.7--canary.2272.26620.0
yarn add @auto-canary/microsoft-teams@10.37.7--canary.2272.26620.0
yarn add @auto-canary/npm@10.37.7--canary.2272.26620.0
yarn add @auto-canary/omit-commits@10.37.7--canary.2272.26620.0
yarn add @auto-canary/omit-release-notes@10.37.7--canary.2272.26620.0
yarn add @auto-canary/pr-body-labels@10.37.7--canary.2272.26620.0
yarn add @auto-canary/released@10.37.7--canary.2272.26620.0
yarn add @auto-canary/s3@10.37.7--canary.2272.26620.0
yarn add @auto-canary/sbt@10.37.7--canary.2272.26620.0
yarn add @auto-canary/slack@10.37.7--canary.2272.26620.0
yarn add @auto-canary/twitter@10.37.7--canary.2272.26620.0
yarn add @auto-canary/upload-assets@10.37.7--canary.2272.26620.0
yarn add @auto-canary/version-file@10.37.7--canary.2272.26620.0
yarn add @auto-canary/vscode@10.37.7--canary.2272.26620.0

@hipstersmoothie hipstersmoothie added the minor Increment the minor version when merged label Feb 3, 2023
@hipstersmoothie hipstersmoothie merged commit 3e79770 into intuit:main Feb 3, 2023
@hipstersmoothie
Copy link
Collaborator

🚀 PR was released in v10.38.0 🚀

@hipstersmoothie hipstersmoothie added the released This issue/pull request has been released. label Feb 4, 2023
@jackw jackw deleted the jackw/no-slack-at-target branch January 18, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants