Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(npm): use version commit message from lerna.json #2277

Conversation

UncleDave
Copy link
Contributor

@UncleDave UncleDave commented Nov 26, 2022

What Changed

Use the user defined lerna version commit message from lerna.json in a monorepo where possible.

Fixes #2276

Why

As described in #2276 - lerna allows the version command's message to be customised, but auto does not currently respect that customisation.

Todo:

  • Add tests
  • Add docs

Unsure if a docs change is warranted as this is functionality present in lerna that auto is using.

Change Type

  • documentation
  • patch
  • minor
  • major

This could possibly be considered a patch change instead of a minor, since not respecting lerna's config for this could be considered a bug.

🐤 Download canary assets:

auto-linux--canary.2277.26629.gz
auto-macos--canary.2277.26629.gz
auto-win.exe--canary.2277.26629.gz

📦 Published PR as canary version: under canary scope @auto-canary@10.38.0--canary.2277.26629.0

✨ Test out this PR locally via:

npm install @auto-canary/bot-list@10.38.0--canary.2277.26629.0
npm install @auto-canary/auto@10.38.0--canary.2277.26629.0
npm install @auto-canary/core@10.38.0--canary.2277.26629.0
npm install @auto-canary/package-json-utils@10.38.0--canary.2277.26629.0
npm install @auto-canary/all-contributors@10.38.0--canary.2277.26629.0
npm install @auto-canary/brew@10.38.0--canary.2277.26629.0
npm install @auto-canary/chrome@10.38.0--canary.2277.26629.0
npm install @auto-canary/cocoapods@10.38.0--canary.2277.26629.0
npm install @auto-canary/conventional-commits@10.38.0--canary.2277.26629.0
npm install @auto-canary/crates@10.38.0--canary.2277.26629.0
npm install @auto-canary/docker@10.38.0--canary.2277.26629.0
npm install @auto-canary/exec@10.38.0--canary.2277.26629.0
npm install @auto-canary/first-time-contributor@10.38.0--canary.2277.26629.0
npm install @auto-canary/gem@10.38.0--canary.2277.26629.0
npm install @auto-canary/gh-pages@10.38.0--canary.2277.26629.0
npm install @auto-canary/git-tag@10.38.0--canary.2277.26629.0
npm install @auto-canary/gradle@10.38.0--canary.2277.26629.0
npm install @auto-canary/jira@10.38.0--canary.2277.26629.0
npm install @auto-canary/magic-zero@10.38.0--canary.2277.26629.0
npm install @auto-canary/maven@10.38.0--canary.2277.26629.0
npm install @auto-canary/microsoft-teams@10.38.0--canary.2277.26629.0
npm install @auto-canary/npm@10.38.0--canary.2277.26629.0
npm install @auto-canary/omit-commits@10.38.0--canary.2277.26629.0
npm install @auto-canary/omit-release-notes@10.38.0--canary.2277.26629.0
npm install @auto-canary/pr-body-labels@10.38.0--canary.2277.26629.0
npm install @auto-canary/released@10.38.0--canary.2277.26629.0
npm install @auto-canary/s3@10.38.0--canary.2277.26629.0
npm install @auto-canary/sbt@10.38.0--canary.2277.26629.0
npm install @auto-canary/slack@10.38.0--canary.2277.26629.0
npm install @auto-canary/twitter@10.38.0--canary.2277.26629.0
npm install @auto-canary/upload-assets@10.38.0--canary.2277.26629.0
npm install @auto-canary/version-file@10.38.0--canary.2277.26629.0
npm install @auto-canary/vscode@10.38.0--canary.2277.26629.0
# or 
yarn add @auto-canary/bot-list@10.38.0--canary.2277.26629.0
yarn add @auto-canary/auto@10.38.0--canary.2277.26629.0
yarn add @auto-canary/core@10.38.0--canary.2277.26629.0
yarn add @auto-canary/package-json-utils@10.38.0--canary.2277.26629.0
yarn add @auto-canary/all-contributors@10.38.0--canary.2277.26629.0
yarn add @auto-canary/brew@10.38.0--canary.2277.26629.0
yarn add @auto-canary/chrome@10.38.0--canary.2277.26629.0
yarn add @auto-canary/cocoapods@10.38.0--canary.2277.26629.0
yarn add @auto-canary/conventional-commits@10.38.0--canary.2277.26629.0
yarn add @auto-canary/crates@10.38.0--canary.2277.26629.0
yarn add @auto-canary/docker@10.38.0--canary.2277.26629.0
yarn add @auto-canary/exec@10.38.0--canary.2277.26629.0
yarn add @auto-canary/first-time-contributor@10.38.0--canary.2277.26629.0
yarn add @auto-canary/gem@10.38.0--canary.2277.26629.0
yarn add @auto-canary/gh-pages@10.38.0--canary.2277.26629.0
yarn add @auto-canary/git-tag@10.38.0--canary.2277.26629.0
yarn add @auto-canary/gradle@10.38.0--canary.2277.26629.0
yarn add @auto-canary/jira@10.38.0--canary.2277.26629.0
yarn add @auto-canary/magic-zero@10.38.0--canary.2277.26629.0
yarn add @auto-canary/maven@10.38.0--canary.2277.26629.0
yarn add @auto-canary/microsoft-teams@10.38.0--canary.2277.26629.0
yarn add @auto-canary/npm@10.38.0--canary.2277.26629.0
yarn add @auto-canary/omit-commits@10.38.0--canary.2277.26629.0
yarn add @auto-canary/omit-release-notes@10.38.0--canary.2277.26629.0
yarn add @auto-canary/pr-body-labels@10.38.0--canary.2277.26629.0
yarn add @auto-canary/released@10.38.0--canary.2277.26629.0
yarn add @auto-canary/s3@10.38.0--canary.2277.26629.0
yarn add @auto-canary/sbt@10.38.0--canary.2277.26629.0
yarn add @auto-canary/slack@10.38.0--canary.2277.26629.0
yarn add @auto-canary/twitter@10.38.0--canary.2277.26629.0
yarn add @auto-canary/upload-assets@10.38.0--canary.2277.26629.0
yarn add @auto-canary/version-file@10.38.0--canary.2277.26629.0
yarn add @auto-canary/vscode@10.38.0--canary.2277.26629.0

@hipstersmoothie hipstersmoothie added the minor Increment the minor version when merged label Nov 26, 2022
@UncleDave UncleDave force-pushed the feat/use-version-message-from-lerna-json branch from 9b19093 to 3829561 Compare February 5, 2023 21:25
@UncleDave UncleDave force-pushed the feat/use-version-message-from-lerna-json branch from 3829561 to 647b32f Compare February 5, 2023 22:14
@codecov
Copy link

codecov bot commented Feb 8, 2023

Codecov Report

Merging #2277 (647b32f) into main (98034de) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #2277      +/-   ##
==========================================
- Coverage   80.69%   80.65%   -0.05%     
==========================================
  Files          69       69              
  Lines        5637     5644       +7     
  Branches     1322     1325       +3     
==========================================
+ Hits         4549     4552       +3     
- Misses        711      712       +1     
- Partials      377      380       +3     
Impacted Files Coverage Δ
plugins/npm/src/index.ts 72.91% <100.00%> (+0.32%) ⬆️
plugins/microsoft-teams/src/index.ts 81.81% <0.00%> (-3.64%) ⬇️
plugins/slack/src/index.ts 77.71% <0.00%> (-1.81%) ⬇️
packages/core/src/git.ts 87.05% <0.00%> (+0.27%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@hipstersmoothie hipstersmoothie merged commit 666d042 into intuit:main Feb 8, 2023
@github-actions
Copy link

github-actions bot commented Feb 8, 2023

🚀 PR was released in v10.39.0 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Feb 8, 2023
@UncleDave UncleDave deleted the feat/use-version-message-from-lerna-json branch November 30, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use lerna version commit message from lerna config if specified
2 participants