-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CocoaPods] switch Promise.all for reduce to avoid git lock #2327
Conversation
@hipstersmoothie seems like PRs from forks don't quite play well in GH actions? saw you enabled some PR behavior a few days ago, but no PRs in that time from forks |
Looks like things ran? looks like I might need some extra perms somewhere.... |
Codecov Report
@@ Coverage Diff @@
## main #2327 +/- ##
==========================================
- Coverage 80.62% 80.60% -0.03%
==========================================
Files 69 69
Lines 5668 5662 -6
Branches 1272 1329 +57
==========================================
- Hits 4570 4564 -6
+ Misses 718 717 -1
- Partials 380 381 +1
|
5b32047
to
53489a0
Compare
53489a0
to
4290132
Compare
4290132
to
ce4650d
Compare
@hipstersmoothie i dont know what's wrong with this build, the change here is pretty minor what can i do to get this change in? have a need for prereleases coming up, so i'd like to get this fixed |
I'll take a look tonight |
🚀 PR was released in |
What Changed
Switched
Promise.all
to a reduce a promise chain to avoid git lockI had done this before for the
publish
hook but not for thenext
hookWhy
git lock can be a race condition and sometimes
next
publish will failTodo:
Change Type
Indicate the type of change your pull request is:
documentation
patch
minor
major