Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CocoaPods] switch Promise.all for reduce to avoid git lock #2327

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

hborawski
Copy link
Collaborator

@hborawski hborawski commented Feb 13, 2023

What Changed

Switched Promise.all to a reduce a promise chain to avoid git lock

I had done this before for the publish hook but not for the next hook

Why

git lock can be a race condition and sometimes next publish will fail

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

@hborawski hborawski added the patch Increment the patch version when merged label Feb 13, 2023
@hborawski
Copy link
Collaborator Author

@hipstersmoothie seems like PRs from forks don't quite play well in GH actions? saw you enabled some PR behavior a few days ago, but no PRs in that time from forks

@hipstersmoothie
Copy link
Collaborator

Looks like things ran? looks like I might need some extra perms somewhere....

@codecov
Copy link

codecov bot commented Feb 15, 2023

Codecov Report

Merging #2327 (5b32047) into main (d298578) will decrease coverage by 0.03%.
Report is 4 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head 5b32047 differs from pull request most recent head ce4650d. Consider uploading reports for the commit ce4650d to get more accurate results

@@            Coverage Diff             @@
##             main    #2327      +/-   ##
==========================================
- Coverage   80.62%   80.60%   -0.03%     
==========================================
  Files          69       69              
  Lines        5668     5662       -6     
  Branches     1272     1329      +57     
==========================================
- Hits         4570     4564       -6     
+ Misses        718      717       -1     
- Partials      380      381       +1     
Files Changed Coverage Δ
plugins/cocoapods/src/index.ts 88.62% <100.00%> (+0.13%) ⬆️

... and 7 files with indirect coverage changes

@hborawski
Copy link
Collaborator Author

@hipstersmoothie i dont know what's wrong with this build, the change here is pretty minor

what can i do to get this change in? have a need for prereleases coming up, so i'd like to get this fixed

@hipstersmoothie
Copy link
Collaborator

I'll take a look tonight

@hipstersmoothie hipstersmoothie merged commit beeb948 into intuit:main Aug 10, 2023
6 of 9 checks passed
@github-actions
Copy link

🚀 PR was released in v11.0.1 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants