Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes "some peer dependencies are incorrectly met" when installing via yarn #2348

Merged

Conversation

snebjorn
Copy link
Contributor

What Changed

Adds unmet peer dependencies coming from bundled dependencies.
Namely; ts-node, @endemolshinegroup/cosmiconfig-typescript-loader

Why

Solves warnings when installing auto via yarn, see #2343

Todo:

  • Add tests
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

…script-loader requested by ts-node

```
$ yarn add auto
➤ YN0002: │ @endemolshinegroup/cosmiconfig-typescript-loader@npm:3.0.2 doesn't provide typescript, requested by ts-node

$ yarn explain peer-requirements
➤ YN0000: @endemolshinegroup/cosmiconfig-typescript-loader@npm:3.0.2 doesn't provide typescript, breaking the following requirements:

➤ YN0000: ts-node@npm:9.1.1 → >=2.7 ✘
```

See https://yarnpkg.com/advanced/error-codes#yn0002---missing_peer_dependency

fixes intuit#2343
```
$ yarn add auto
➤ YN0002: │ @auto-it/core@npm:10.43.0 doesn't provide @types/node, requested by ts-node

$ yarn explain peer-requirements
➤ YN0000: @auto-it/core@npm:10.43.0 doesn't provide @types/node, breaking the following requirements:

➤ YN0000: ts-node@npm:10.9.1 → * ✘
```

See https://yarnpkg.com/advanced/error-codes#yn0002---missing_peer_dependency

fixes intuit#2343
@snebjorn snebjorn changed the title fixes some peer dependencies are incorrectly met when installing via yarn fixes "some peer dependencies are incorrectly met" when installing via yarn Mar 23, 2023
@snebjorn
Copy link
Contributor Author

if there'll be a canary release of this I can test that it works as expected :)

@codecov
Copy link

codecov bot commented Apr 3, 2023

Codecov Report

Merging #2348 (20d36a2) into main (f7827d4) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2348      +/-   ##
==========================================
- Coverage   80.67%   80.60%   -0.08%     
==========================================
  Files          69       69              
  Lines        5662     5662              
  Branches     1271     1271              
==========================================
- Hits         4568     4564       -4     
- Misses        716      717       +1     
- Partials      378      381       +3     

see 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@snebjorn
Copy link
Contributor Author

snebjorn commented Apr 3, 2023

pr-check and release seems to fail due to

⚠  warning   protected-branch: No "PROTECTED_BRANCH_REVIEWER_TOKEN" found in environment
Error: Failed to post status to Pull Request with error code 404

and not sure what to do about the codecov. Don't think a test can cover package.json 😄

@hipstersmoothie hipstersmoothie merged commit 52bb27e into intuit:main Apr 26, 2023
6 of 9 checks passed
@github-actions
Copy link

🚀 PR was released in v10.45.1 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants