Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow pr check on old version branches #2388

Merged

Conversation

jBouyoud
Copy link
Contributor

@jBouyoud jBouyoud commented Aug 25, 2023

What Changed

Do not exit with code 1 when running prCheck on old version branches

Why

To mimic the same behavior as for main or pre-release branches

Todo:

  • Add tests : Since code use exit seems hard to tests , and existing condition are not tested
  • Add docs

Change Type

Indicate the type of change your pull request is:

  • documentation
  • patch
  • minor
  • major

@codecov
Copy link

codecov bot commented Aug 25, 2023

Codecov Report

Merging #2388 (84a5245) into main (beeb948) will decrease coverage by 0.08%.
Report is 4 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2388      +/-   ##
==========================================
- Coverage   80.63%   80.56%   -0.08%     
==========================================
  Files          69       69              
  Lines        5670     5670              
  Branches     1272     1272              
==========================================
- Hits         4572     4568       -4     
- Misses        718      719       +1     
- Partials      380      383       +3     
Files Changed Coverage Δ
packages/core/src/auto.ts 77.92% <ø> (ø)

... and 3 files with indirect coverage changes

@hipstersmoothie hipstersmoothie merged commit 6d4d083 into intuit:main Sep 6, 2023
6 of 9 checks passed
@jBouyoud jBouyoud deleted the pr-check-on-old-version-branches branch September 7, 2023 07:27
@github-actions
Copy link

🚀 PR was released in v11.0.3 🚀

@github-actions github-actions bot added the released This issue/pull request has been released. label Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants