Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow Renderer#render to take a hash of CSL input data #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jrochkind
Copy link
Contributor

Doesn't yet have a spec/features, but needs one. I am having trouble
figuring out where to fit it in to the existing spec structure how, can
you advise @inukshuk on some hints as to what a good spec for this would look like? (I hope not a cucumber features, cause cucumber drives me crazy)

ref #55
ref #53

@jrochkind
Copy link
Contributor Author

oops, failing travis for real. I'll look into it.

@jrochkind
Copy link
Contributor Author

Uh, it looks like contrary to docs CiteProc::CitationItem was not the only legal thing to pass into Renderer#render. Something... else was being passed in in tests, which my code turns into a CiteProc::CitationItem and ruins it.

Trying to debug, but appreciate any ideas.

@jrochkind
Copy link
Contributor Author

it looks like maybe everything is maybe some kind of CiteProc::Attributes, of which CiteProc::CitationItem is one example. Perhaps the doc @param should note that, not sure.

Do note that it looks like Renderer#render is used "under the hood" in things, changes we make there, if they effect performance, may effect other things than top-level manual use of Renderer#render. But I'm not too worried about it.

@krzysiek1507
Copy link

Hi! Any chance to merge it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants