Implement rollup & .d.ts generator #1372
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardssh
requested review from
benedyktdryl,
PodaruDragos,
dcavanagh,
tonyhallett and
notaphplover
2 tasks
|
Apparently, it's not as easy as I'd hoped, there's a bit more work to do on the testing side. 😅 |
| "types": ["mocha", "reflect-metadata"], | ||
| "moduleResolution": "node", | ||
| "sourceMap": true, | ||
| "jsx": "react", |
| @@ -0,0 +1,3 @@ | |||
| (async () => { | |||
There was a problem hiding this comment.
clean-dist and remove-dist could be done using rm -rf dist/ i assume
no need to import packages for that.
| } | ||
| }, | ||
| treeshake: { | ||
| moduleSideEffects: false |
| "sinon": "9.2.4", | ||
| "ts-node": "9.1.1", | ||
| "tsify": "5.0.2", | ||
| "tslint": "6.1.3", | ||
| "typescript": "4.2.4", | ||
| "updates": "12.0.2" | ||
| }, | ||
| "prettier": { |
There was a problem hiding this comment.
what's up with prettier here ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements rollup bundling and
.d.tsgenerator using @microsoft/api-extractor.Related Issue
#1371
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: