chore(): include src to fix sourcemaps #1398
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pp_1 | WARNING in ../../node_modules/inversify/es/utils/js.js
app_1 | Module Warning (from ../../node_modules/source-map-loader/dist/cjs.js):
app_1 | Failed to parse source map from '/project/node_modules/inversify/src/utils/js.ts' file: Error: ENOENT: no such file or directory, open '/project/node_modules/inversify/src/utils/js.ts'
app_1 | @ ../../node_modules/inversify/es/annotation/decorator_utils.js 3:0-53 26:24-46
app_1 | @ ../../node_modules/inversify/es/inversify.js 6:0-69 6:0-69 21:0-56 21:0-56
app_1 | @ ../../node_modules/@woodmac-lens/app/esm/enhancer.js 2:0-38 41:59-68 42:27-36
app_1 | @ ../../node_modules/@woodmac-lens/app/esm/index.js 20:0-49 20:0-49
app_1 | @ ./src/externals.ts 6:0-49 18:0-52 27:23-37 39:35-47
app_1 |
app_1 | WARNING in ../../node_modules/inversify/es/utils/serialization.js
app_1 | Module Warning (from ../../node_modules/source-map-loader/dist/cjs.js):
app_1 | Failed to parse source map from '/project/node_modules/inversify/src/utils/serialization.ts' file: Error: ENOENT: no such file or directory, open '/project/node_modules/inversify/src/utils/serialization.ts'
app_1 | @ ../../node_modules/inversify/es/inversify.js 23:0-69 23:0-69
app_1 | @ ../../node_modules/@woodmac-lens/app/esm/enhancer.js 2:0-38 41:59-68 42:27-36
app_1 | @ ../../node_modules/@woodmac-lens/app/esm/index.js 20:0-49 20:0-49
app_1 | @ ./src/externals.ts 6:0-49 18:0-52 27:23-37 39:35-47
app_1 |
app_1 | 53 warnings have detailed information that is not shown.
app_1 | Use 'stats.errorDetails: true' resp. '--stats-error-details' to show it.
app_1 | See example of error |
jmfrancois
approved these changes
Feb 7, 2023
There was a problem hiding this comment.
I do not have right on the repo but clearly way better option than #1412
The corresponding revert commit
b9442cc
but seems against maintainer opinion, the bug is still open after a year.
look at https://unpkg.com/browse/inversify@6.0.1/lib/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include src folder in published package. This is require to fix source maps on webpack and simmilar.
I made this change few weeks ago but it was reversed #1366