Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to typings #55

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

MutantPiggieGolem1
Copy link

This was in effect a basic replacement of js_bindings with typings
Major Changes include:

  • No longer using a wrapper over the Request class
  • No longer using a wrapper over whatever crypto was
  • Removal of RequestDuplex
  • Formatting (my formatter's line length is longer, sorry)

@CLAassistant
Copy link

CLAassistant commented Sep 24, 2023

CLA assistant check
All committers have signed the CLA.

@Ehesp
Copy link
Member

Ehesp commented Oct 10, 2023

@MutantPiggieGolem1 thanks a lot for this.

I've made some changes, primarily reverting the removal of the Request class, since we without it we're depending on the interop layer Request, which (for good reason) doesn't provide a strong type definitions as we'd like and could change at any time.

I have one issue left, the FetchEvent class changes you made wouldn't work, since it creates a circular reference to itself (so Dart thinks it's fixed, when in reality it is not). It seems as though the typings package does not provide the FetchEvent types. It's defined in the TypeScript types here but doesn't seem to be exported to Dart. An issue needs to be made over there (if you could make it, that'd be super useful) to bring it in.

However saying that, I'm not sure whether we actually need it for Dart Edge. It's an API of addEventListener, which we don't seemingly use since we generate the event listener code in JS land via the CLI. So we could get rid of it, as I assume no one is using it?

@jodinathan
Copy link

I've published a new version with bug fixes and WebWorker.

please do some tests and add issues in https://github.com/jodinathan/typings/issues if anything comes up

@dshukertjr
Copy link

Hi there,

Just checking here, but do we need additional changes to be made for this PR to be merged?

@bigbenyayi
Copy link

Any ideas when this PR will be merged? Dart Edge is none functional it doesn't even compile...

@alaincruz06
Copy link

Strongly waiting for this PR to be merged or another release from the team. Can't compile more functions until this typings migration is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants