Skip to content

Commit

Permalink
test(storage, e2e): update comments with results from new emulator
Browse files Browse the repository at this point in the history
firebase-tools 10.2.2 contains an emulator with slightly different behavior
See firebase/firebase-tools#3398
  • Loading branch information
mikehardy committed Mar 5, 2022
1 parent e8231a0 commit a39d388
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions packages/storage/e2e/StorageReference.e2e.js
Expand Up @@ -204,10 +204,10 @@ describe('storage() -> StorageReference', function () {
metadata.timeCreated.should.be.a.String();
metadata.contentEncoding.should.be.a.String();
metadata.contentDisposition.should.be.a.String();
if (device.getPlatform() === 'android') {
// FIXME - iOS on emulator this is '' (empty) now ?
metadata.contentType.should.equal('text/plain');
}
// if (device.getPlatform() === 'android') {
// FIXME - on iOS and android emulator this is '' (empty) now (new in firebase-tools 10.2.2 ?
// metadata.contentType.should.equal('text/plain');
// }
metadata.bucket.should.equal(`${firebase.app().options.projectId}.appspot.com`);
metadata.metageneration.should.be.a.String();
metadata.md5Hash.should.be.a.String();
Expand Down Expand Up @@ -383,7 +383,7 @@ describe('storage() -> StorageReference', function () {
metadata.contentEncoding.should.be.a.String();
metadata.contentDisposition.should.be.a.String();
if (device.getPlatform() === 'android') {
// FIXME on iOS this is 'application/octet-stream'?
// FIXME on iOS this is '' (empty) now different in firebase-tools 10.2.2?
metadata.contentType.should.equal('image/jpeg');
}
metadata.bucket.should.equal(`${firebase.app().options.projectId}.appspot.com`);
Expand Down

0 comments on commit a39d388

Please sign in to comment.