Merge pull request #32 from invisible-tech/lkk/timber

Fix Timber.io Blank Messages Error
invisible-tech · Feb 14, 2018 · 4124bef · 4124bef
2 parents 3b1ba10 + e03e5ec
commit 4124bef
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,6 @@
+*v1.1.1*
+> Fix: Blank messages bug when logging an Error object using Timber.io
+
 *v1.1.0*
 > Feat: Add Timber.io transport
 

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@invisible/logger",
-  "version": "1.1.0",
+  "version": "1.1.1",
   "description": "Invisible Logging Wrapper",
   "main": "index.js",
   "scripts": {

diff --git a/transports/console.js b/transports/console.js
@@ -25,7 +25,11 @@ if (shouldLog && TIMBER_KEY) {
   transport = new (winston.transports.Console)({
     name: 'console',
     level: TIMBER_LEVEL,
-    formatter: timber.formatters.Winston,
+    formatter: options => {
+      // When we log errors, options.message comes as blank and it causes errors
+      const message = options.message || options.meta.message
+      return timber.formatters.Winston({ ...options, message })
+    },
   })
 } else if (shouldLog) {
   transport = new (winston.transports.Console)({