feat: add build-adapter command to compile with ESBuild #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlCalzone
force-pushed
the
build-script
branch
from
8ee0cc9
to
81d4e50
Compare
AlCalzone
changed the title
UncleSamSwiss
requested changes
Feb 13, 2022
| if (watch) { | ||
| // In watch mode, we start the ESBuild and TSC processes in parallel | ||
| // and wait until they end | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars |
There was a problem hiding this comment.
Why have the build variable here if it is not needed?
There was a problem hiding this comment.
I initially had it in use and called stop() on it, but it seems that esbuild checks for SIGINT itself. Until I'm sure if this is a bug in esbuild or intended, I wanted to leave it in for easy access:
evanw/esbuild#2007
| if (watch) { | ||
| // In watch mode, we start the ESBuild and TSC processes in parallel | ||
| // and wait until they end | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars |
src/build-adapter-handlers.ts
Outdated
| // In watch mode, we start the ESBuild and TSC processes in parallel | ||
| // and wait until they end | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| const { build: buildReact, check: checkReact } = await watchReact(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for a custom
buildcommand that uses ESBuild under the hood.Because ESBuild does not do type checking (hence why it is so frigging fast),
tscis executed in check mode after each successful build.In addition, there is a watch mode where both ESBuild and tsc are executed in parallel, compiling and checking files whenever they change.