Passenger API | Ticketing #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tom-ioki
approved these changes
May 8, 2024
The `nil` approach changes the behavior when supplying a model you might not know that it's `nil`. Before it raised, the new behavior is that it no longer raises, but sends an empty body to the API. `outgoing_model_class` is an optional argument which defaults to `nil`. We therefore cannot use `nil` to specify that the body should be empty. We use `:empty` instead to denote that the request should send an empty body.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds all model and endpoints related to ticketing to the passenger API.
There are also two additional changes:
Ioki::Model::Passenger. For Ticketing it makes sense to namespace all ticketing models inIoki::Model::Passenger::Ticketing. Such subfolders were not yet loaded though (inlib/ioki/model.rb).POSTrequests with an empty body. You still have to passnilto the method though:passenger_client.create_my_model('my_id', nil)