Allow setting a padding on android icons

[muuvmuuv]

Adds an option --android-resize, that allows scaling the source image for modern icons (API>24).

Closes #118

[muuvmuuv]

Played a little bit around and this seems not really possible with the current options. The closest I came was to avoid applying the scale to the legacy items (which require a padding by default).

[muuvmuuv]

Images of scaling 30 and 80:

The two on the right are the legacy ones which are generated from "icon-only" or "android/icon". These cannot be scaled atm because them would require to have foreground and background separated which is currently not implemented that way because all assets are looped and therefore the "icon-only" overrides the previous comb of fore- and background.

[mlynch]

I think the only one that really needs any padding possibly is the round and legacy launcher icons. Let me know when you want me to take another look. We can figure out what option we want to call this later but I agree with the functionality

[muuvmuuv]

Yes. From what I saw in Android Studio and Google is that by default it creates a padding around the legacy icons (when you right-click and generate an image asset resource). So, I wouldn't make this an option but apply it by default (as before).

Having a resize method to scale the foreground would make sense in case of Android. From two of my projects, I had to scale to 65% of what looked perfectly on iOS. IDK why Android does that zooming, and it is just relevant for API above 29.

[muuvmuuv]

Another test with the latest main Branch merged into this.

Source assets: assets.zip

Command: capacitor-assets generate --android-resize=64

Result:

Android	With res	Without
till 7
8 - 13

I think --android-resize fit's pretty well, even if it is just used in _generateAdaptiveIconForeground, and it looks exactly what #118 wants. But I think I forgot something. Lets see if someone from the issue can test this by itself.

[noahbrenner]

This might be addressed by #424, if folks think that's a good approach to the Android scaling issue.

[mlynch]

Just gave it a test and it appears to be working for me

Any idea whether this padding needs to be adjusted to account for the inset for adaptive icons done in #424?

Also I think --androidIconScale would be a better name since this is a percentage scale not specific pixel value

[noahbrenner]

From the two links below, I'm wondering if the <background> should actually not have the inset I added in #424, so that it allows for the intended bleed for the various ways the icon can be displayed. At the same time, the info at these links make me more confident that the inset is the correct approach for the foreground.

https://developer.android.com/develop/ui/views/launch/icon_design_adaptive
https://developer.android.com/studio/write/image-asset-studio

[co-dax]

When will this change will be released?

[co-dax]

@mlynch, @muuvmuuv I have tested this and it works fine.
I would say this option pretty much urgent as otherwise as a workaround we would need to manual (or via some code) scale down foreground icon (assets/icon-foreground.png) by around 67% and it would work fine even without this change.
@muuvmuuv As for why Android is "zooming" the icon...it is not actually zooming the icon it is just taking advantage of the non safe area that is allowed to be trimmed/shaped by OEMs (if I am not missing something). Here it is the related link https://developer.android.com/develop/ui/views/launch/icon_design_adaptive

[noahbrenner]

@co-dax Does the most recent version work for you, after #424 was merged (v2.0.1 or later)?

[co-dax]

@muuvmuuv, @mlynch version 2.0.4 (latest) does not work for me while the change on your branch does work.

I can see that this branch has been merged but only one file seems to be merged https://github.com/ionic-team/capacitor-assets/pull/424/files. Also when we navigate to your branch there is an additional usage description:

--android-resize - resize the non-legacy android icons based on a percentage.

...but when we navigate to the latest verion branch there is so such usage description which seems to confirm that the branch has only been partially merged.

[muuvmuuv]

@co-dax because my branch is not the master in here and still a draft we are discussing. #424 was a good workaround without additional needs of options. But I agree that this workaround also scales the background and my solution just adds a "padding" to the foreground.

[co-dax]

@muuvmuuv thanks, I actually have confused the two branches :-).
Your branch seems to be working fine. I will try using it in production and will keep you informed.

Thanks everyone.