Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(angular RouterLinkDelegateDirective): Make routerLink respect target and keyboard modifiers #28976

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(angular RouterLinkDelegateDirective): Make routerLink respect target and keyboard modifiers #28976

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
23 changes: 23 additions & 0 deletions packages/angular/common/src/directives/navigation/router-link-delegate.ts
View file
Open in desktop
Expand Up @@ -49,6 +49,29 @@ export class RouterLinkDelegateDirective implements OnInit, OnChanges {
*/
@HostListener('click', ['$event'])
onClick(ev: UIEvent): void {
/**
* Using a target different from _self will
* open another browser tab.
* Therefore, use default
* behaviour of this event.
*/
if (this.elementRef.nativeElement.target === undefined || this.elementRef.nativeElement.target !== '_self') {
return;
}

/**
* Using a keyboard modifier will
* open another browser tab.
* Therefore, use default
* behaviour of this event.
*/
if (
(ev instanceof MouseEvent || ev instanceof TouchEvent)
&& (ev.altKey || ev.ctrlKey || ev.metaKey || ev.shiftKey)
) {
return;
}

this.navCtrl.setDirection(this.routerDirection, undefined, undefined, this.routerAnimation);

/**
Expand Down