chore(): create reusable test header #29240
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented
There's now a reusable header component that will allow a developer of Ionic Framework to toggle a number of things while viewing the index.html test files. This component can be reused across any of these files and includes:
It also has a slot so that settings can be added, e.g. settings that are specific to the component being tested like the ones we have for some Datetime tests.
Yet to do
I wasn't sure where to put the test-header.tsx file nor did I figure out how to prevent it from being included in Ionic Framework.
Other functionality we might want to add to the popover:
Currently, not all of the options persist when selecting other options. Several of the options are settable via URL query parameters. We may want to update the component to add and remove params accordingly (like it currently does for
theme
, so they will persist.Other information