New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chip): set default shape to soft for ios and md theme and round for ionic theme #29375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brandyscarney
commented
Apr 22, 2024
brandyscarney
commented
Apr 22, 2024
brandyscarney
commented
Apr 22, 2024
...ents/chip/test/a11y/chip.e2e.ts-snapshots/chip-large-contents-md-ltr-Mobile-Chrome-linux.png
Outdated
Show resolved
Hide resolved
brandyscarney
changed the title
feat(chip): set soft as the default shape for all themes
feat(chip): set soft as the default shape for ios and md theme, round for ionic theme
Apr 24, 2024
brandyscarney
changed the title
feat(chip): set soft as the default shape for ios and md theme, round for ionic theme
feat(chip): set default shape to soft for ios and md theme and round for ionic theme
Apr 24, 2024
brandyscarney
commented
Apr 24, 2024
sean-perkins
reviewed
May 1, 2024
brandyscarney
requested review from
sean-perkins
and removed request for
liamdebeasi
May 3, 2024 16:16
sean-perkins
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
The
shape
property defaults toundefined
which evaluates to the "Soft" shape for theionic
theme and the "Round" shape for theios
/md
themes.ionic
)ios
)md
)undefined
4px
16px
16px
"round"
999px
"rectangular"
0px
What is the new behavior?
ionic
)ios
)md
)"soft"
4px
10px
8px
"round"
999px
999px
999px
"rectangular"
0px
0px
0px
shape
property to"soft"
forios
andmd
themes and"round"
for the ionic theme.border-radius
to apply to the shape classes instead of:host
ios
theme to use10px
for"soft"
as this was taken from the App Store:md
theme to use8px
for"soft"
as this is taken from the Material Design 3 guidelines & the previous value of16px
is the equivalent of the999px
round shape due to the height being32px
"round"
and"rectangular"
shapes inios
andmd
themesDoes this introduce a breaking change?
BREAKING CHANGE:
The
border-radius
of theios
andmd
chip now defaults to10px
and8px
, respectively, instead of16px
in accordance with the iOS and Material Design 3 guidelines. To revert to the previous appearance, set theshape
to"round"
, or override the--border-radius
CSS variable to specify a different value.