New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(card): set round as the default shape for all themes #29387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brandyscarney
changed the title
Fw 6193
feat(card): set round as the default shape for all themes
Apr 23, 2024
sean-perkins
approved these changes
Apr 24, 2024
brandyscarney
commented
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
The
shape
property defaults toundefined
which evaluates to the "Soft" shape for all themes.ionic
)ios
)md
)undefined
4px
8px
4px
"round"
16px
"rectangular"
0px
What is the new behavior?
ionic
)ios
)md
)"soft"
4px
8px
4px
"round"
16px
14px
12px
"rectangular"
0px
0px
0px
"soft"
shape using the existing values forundefined
shape
property to"round"
for all themes and updates theborder-radius
to apply to the shape classes instead of:host
"round"
and"rectangular"
shapes inios
andmd
ios
theme to use14px
for"round"
as this is taken from the card in the iOS App Storemd
theme to use12px
for"round"
as this is taken from the Material Design 3 guidelinesDoes this introduce a breaking change?
BREAKING CHANGE:
The
border-radius
of theios
andmd
card now defaults to14px
and12px
instead of8px
and4px
, respectively, in accordance with the iOS and Material Design 3 guidelines. To revert to the previous appearance, set theshape
to"soft"
, or override the--border-radius
CSS variable to specify a different value.