New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(input): match medium size for ionic theme #29403
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These look plain because underlined hasn't been implemented yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question around the z-index
value, otherwise changes look good.
Sean approved this, so going to remove myself from review. Let me know if you'd still like me to take a look though! |
Issue number: internal
What is the current behavior?
There is only one size, large, for
ionic
theme. Developers can also leave it undefined and no styles will be applied.What is the new behavior?
medium
size has been added. It's also being used as the default.Does this introduce a breaking change?
Other information
Verify that interactive elements can be accessed in the start and end slots along with the clear icon button.
Preview