Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(core): ionChange will not emit from programmatically changing value #29407

Merged
merged 2 commits into from Apr 26, 2024

Conversation

sean-perkins
Copy link
Contributor

Issue number: resolves ionic-team/ionic-docs#3588


What is the current behavior?

The documentation around ionChange not being emitted when programmatically changing the property associated to the "value" is either inconsistent or missing from certain components.

What is the new behavior?

  • Adds the documentation to the missing components.
  • Makes the documentation consistent across components.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Copy link

vercel bot commented Apr 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 26, 2024 6:53pm

@github-actions github-actions bot added package: core @ionic/core package package: angular @ionic/angular package labels Apr 26, 2024
@sean-perkins sean-perkins changed the title docs(core): ionChange will not emit from programmatic value changes docs(core): ionChange will not emit from programmatically changing value Apr 26, 2024
@sean-perkins sean-perkins marked this pull request as ready for review April 26, 2024 16:48
@sean-perkins sean-perkins requested a review from a team as a code owner April 26, 2024 16:48
core/src/components/segment/segment.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sean-perkins sean-perkins added this pull request to the merge queue Apr 26, 2024
Merged via the queue into main with commit ca01fe8 Apr 26, 2024
46 checks passed
@sean-perkins sean-perkins deleted the sp/ion-change-docs branch April 26, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ion-segment, ionChange should explain it is not fired when value changed programmatically
2 participants