feat(input): add the readonly styles for the ionic theme #29483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
brandyscarney
changed the title
thetaPC
reviewed
May 9, 2024
| @@ -7,6 +7,8 @@ | |||
| // -------------------------------------------------- | |||
|
|
|||
| :host { | |||
| // TODO(ROU-5477): use design token here when it is added | |||
| --color: #121212; | |||
There was a problem hiding this comment.
Was it verified that it's going to be added? Else we might need to reach out to the designers to verify that this hex is the correct value. Figma has inconsistency for the value, it says #121212 / Neutral/Neutrals 900 but --ionic-color-neutral-900 value does not match.
There was a problem hiding this comment.
Yes I have verified that the design tokens for state have yet to be added. I actually asked about this specific hex before because I ran into it in other components. They are planned in ROU-4870 which is linked as a blocker to the ticket I added here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: internal
What is the current behavior?
There are no custom styles when readonly is added to an input.
What is the new behavior?
input-readonlyclass when thereadonlyproperty istrueionictheme to match the design requirements for readonly inputsfilland"outline"fillDoes this introduce a breaking change?
Other information
Preview