Skip to content

Commit

Permalink
docs(puppeteer): update support table (#932)
Browse files Browse the repository at this point in the history
this commit updates the support table for puppeteer versions for stencil
v3. it serves as the documentation for ionic-team/stencil#3810

this commit updates the puppeteer section of the breaking_changes
document to clarify the version of puppeteer that is supported
  • Loading branch information
rwaskiewicz committed Nov 30, 2022
1 parent 993dfb6 commit e33f4de
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 8 deletions.
8 changes: 5 additions & 3 deletions src/docs/introduction/upgrading-to-stencil-three.md
Expand Up @@ -257,15 +257,17 @@ Replace all instances of `addDestory` with `addDestroy` and all instances of `re
The functionality of these methods remains the same.

## End-to-End Testing
### Puppeteer v10 Required
### Puppeteer v10+ Required
Versions of Puppeteer prior to Puppeteer version 10 are no longer supported.
In newer versions of Puppeteer, the library provides its own types, making `@types/puppeteer` no longer necessary.
Ensure that Puppeteer v10 is installed, and that its typings are not:
Ensure that Puppeteer v10 or higher is installed, and that its typings are not:
```bash
$ npm install puppeteer@10
$ npm install puppeteer
$ npm uninstall @types/puppeteer
```

To see which versions of Puppeteer are supported by Stencil, please see our [support matrix](/docs/support-policy#puppeteer)

## Need Help Upgrading?

Be sure to look at the Stencil [v3.0.0 Breaking Changes Guide](https://github.com/ionic-team/stencil/blob/main/BREAKING_CHANGES.md#stencil-v300).
Expand Down
10 changes: 5 additions & 5 deletions src/docs/reference/support-policy.md
Expand Up @@ -126,8 +126,8 @@ please see [this document](https://github.com/ionic-team/stencil/blob/main/docs/

#### Puppeteer

| Stencil Version | Puppeteer v5-9 | Puppeteer v10 | Puppeteer v11 | Puppeteer v12 | Puppeteer v13 |
|:---------------:|:--------------:|:-------------:|:-------------:|:-------------:|:-------------:|
| V3 | ❌ | ✅ | ✅ | ✅ | ✅ |
| V2 | ✅ | ✅ | ❌ | ❌ | ❌ |
| V1 | ✅ | ❌ | ❌ | ❌ | ❌ |
| Stencil Version | Puppeteer v5-9 | Puppeteer v10 | Puppeteer v11-18 | Puppeteer v19 |
|:---------------:|:--------------:|:-------------:|:----------------:|:-------------:|
| V3 | ❌ | ✅ | ✅ | ✅ |
| V2 | ✅ | ✅ | ❌ | ❌ |
| V1 | ✅ | ❌ | ❌ | ❌ |

0 comments on commit e33f4de

Please sign in to comment.