docs(extras): add conditional slot rendering to experimentalSlotFixes #1374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this pr accompanies ionic-team/stencil#5365, which is the fix for https://github.com/ionic-team/stencil/issue/5335
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rwaskiewicz
commented
Mar 13, 2024
| @@ -104,6 +104,7 @@ with the intent of making these the default behavior in Stencil v5. When set to | |||
| - Failed to execute 'removeChild' on 'Node' [(#3278)](https://github.com/ionic-team/stencil/issues/3278) (since v4.9.0) | |||
| - React fails to manage children in Stencil slot [(#2259)](https://github.com/ionic-team/stencil/issues/2259) (since v4.9.0) | |||
| - Slot name is not updated when it is bind to a prop [(#2982)](https://github.com/ionic-team/stencil/issues/2982) (since 4.12.1) | |||
| - Conditionally rendered slots not working [(#5335)](https://github.com/ionic-team/stencil/issues/5335) (since 4.13.0) | |||
There was a problem hiding this comment.
The PR itself looks good to me, so I'm making assumptions about the version here
rwaskiewicz
requested review from
christian-bromann and
alicewriteswrongs
and removed request for
a team
tanner-reits
approved these changes
Mar 13, 2024
christian-bromann
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
ionic-team/stencil#5335 seems like more an umbrella issue that covers a bunch of other issues. I wonder if it makes sense to link to the PR directly that fixed conditionally rendered slot which is ionic-team/stencil#5365
Either way, both works for me.
|
I had considered both, either works for me as well - I sided on using the issue with consistency with the rest of the docs. Happy to change it if anyone has strong opinions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this pr accompanies ionic-team/stencil#5365, which is the fix for https://github.com/ionic-team/stencil/issue/5335
