Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update stencil core peerDependency value #244

Merged
merged 1 commit into from
Mar 29, 2023

Conversation

vaibhavshn
Copy link
Contributor

@vaibhavshn vaibhavshn commented Mar 29, 2023

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Tests (npm test) were run locally and passed
  • Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

When installing the package in a monorepo and upgrading stencil core to v3, this peerDep value causes it to de-dupe the core package and uses v2 in some places and causes type errors in stencil.config.ts due to mismatched versions.

GitHub Issue Number: N/A

What is the new behavior?

Works with @stencil/core v3

Does this introduce a breaking change?

  • Yes
  • No

Testing

N/A

Other information

N/A

@vaibhavshn vaibhavshn requested a review from a team as a code owner March 29, 2023 06:59
Copy link
Member

@rwaskiewicz rwaskiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vaibhavshn! I had one small ask before we move forward with this.

package.json Show resolved Hide resolved
@rwaskiewicz rwaskiewicz added the Awaiting Reply This PR or Issue needs a reply from the original responder. label Mar 29, 2023
@vaibhavshn
Copy link
Contributor Author

Requested changes were made.

@ionitron-bot ionitron-bot bot removed the Awaiting Reply This PR or Issue needs a reply from the original responder. label Mar 29, 2023
Copy link
Member

@rwaskiewicz rwaskiewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rwaskiewicz rwaskiewicz merged commit 9b156a0 into ionic-team:main Mar 29, 2023
@vaibhavshn vaibhavshn deleted the fix-peer-dep branch March 29, 2023 12:52
@rwaskiewicz rwaskiewicz added Bug: Validated This PR or Issue is verified to be a bug within Stencil Store and removed Bug: Validated This PR or Issue is verified to be a bug within Stencil Store labels Mar 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug: Validated This PR or Issue is verified to be a bug within Stencil Store
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants