Skip to content

Commit

Permalink
fix(typings): add additional transition events to DOMAttributes (#4645)
Browse files Browse the repository at this point in the history
this commit adds function declarations for the following events:
- [`onTransitionCancel`](https://developer.mozilla.org/en-US/docs/Web/API/Element/transitioncancel_event)
- [`onTransitionRun`](https://developer.mozilla.org/en-US/docs/Web/API/Element/transitionrun_event)
- [`onTransitionStart`](https://developer.mozilla.org/en-US/docs/Web/API/Element/transitionstart_event)

note that `onTransitionCancel` was  not natively supported by Chrome &
Edge until v87. this version falls _after_ stencil's currently supported
version of v79+ for both. this commit does not transpile code for the
event/provide a polyfill for versions of Chrome/Edge released before
2020.11.17

fixes: #4643
  • Loading branch information
rwaskiewicz committed Aug 1, 2023
1 parent 0ec52a9 commit 420052f
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions src/declarations/stencil-public-runtime.ts
Expand Up @@ -1805,8 +1805,14 @@ export namespace JSXBase {
onAnimationIterationCapture?: (event: AnimationEvent) => void;

// Transition Events
onTransitionCancel?: (event: TransitionEvent) => void;
onTransitionCancelCapture?: (event: TransitionEvent) => void;
onTransitionEnd?: (event: TransitionEvent) => void;
onTransitionEndCapture?: (event: TransitionEvent) => void;
onTransitionRun?: (event: TransitionEvent) => void;
onTransitionRunCapture?: (event: TransitionEvent) => void;
onTransitionStart?: (event: TransitionEvent) => void;
onTransitionStartCapture?: (event: TransitionEvent) => void;
}
}

Expand Down

0 comments on commit 420052f

Please sign in to comment.