Skip to content

Commit

Permalink
chore(node): update support to node v22
Browse files Browse the repository at this point in the history
This bumps us up to node v22 by:

- adding it to CI
- bumping volta
- changing renovatebot config stuff

STENCIL-1257
  • Loading branch information
alicewriteswrongs committed May 8, 2024
1 parent b0a9f7b commit 7380380
Show file tree
Hide file tree
Showing 10 changed files with 14 additions and 13 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/test-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: ['16', '18', '20']
node: ['16', '18', '20', '22']
os: ['ubuntu-latest', 'windows-latest']
runs-on: ${{ matrix.os }}
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-component-starter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
fail-fast: false
matrix:
jest: ['24', '25', '26', '27', '28', '29']
node: ['16', '18', '20']
node: ['16', '18', '20', '22']
os: ['ubuntu-latest', 'windows-latest']
runs-on: ${{ matrix.os }}
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-docs-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: ['16', '18', '20']
node: ['16', '18', '20', '22']
os: ['ubuntu-latest', 'windows-latest']
runs-on: ${{ matrix.os }}
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: ['16', '18', '20']
node: ['16', '18', '20', '22']
os: ['ubuntu-latest', 'windows-latest']
runs-on: ${{ matrix.os }}
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-unit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node: ['16', '18', '20']
node: ['16', '18', '20', '22']
os: ['ubuntu-latest', 'windows-latest']
runs-on: ${{ matrix.os }}
steps:
Expand Down
8 changes: 4 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
"@types/graceful-fs": "^4.1.5",
"@types/jest": "^27.0.3",
"@types/listr": "^0.14.4",
"@types/node": "^20.1.1",
"@types/node": "^20.12.11",
"@types/pixelmatch": "^5.2.4",
"@types/pngjs": "^6.0.1",
"@types/prompts": "^2.0.9",
Expand Down Expand Up @@ -150,7 +150,7 @@
],
"prettier": "@ionic/prettier-config",
"volta": {
"node": "20.12.2",
"node": "22.1.0",
"npm": "10.7.0"
}
}
2 changes: 1 addition & 1 deletion renovate.json5
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@
packageRules: [
{
matchPackageNames: ['@types/node'],
allowedVersions: '<21.0.0',
allowedVersions: '<23.0.0',
},
{
// Increment this value as a part of updating TypeScript
Expand Down
2 changes: 1 addition & 1 deletion src/utils/test/util.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ describe('util', () => {
const expectedDiagnostic: d.Diagnostic = stubDiagnostic({
absFilePath: mockPackageJsonPath,
header: 'Error Parsing JSON',
messageText: expect.stringMatching(/.*in JSON at position 13$/),
messageText: expect.stringMatching(/.*in JSON at position 13/),
type: 'build',
});

Expand Down
1 change: 1 addition & 0 deletions tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@
},
"pretty": true,
"resolveJsonModule": true,
"skipLibCheck": true,
"sourceMap": true,
"strictBindCallApply": true,
"strictFunctionTypes": true,
Expand Down

0 comments on commit 7380380

Please sign in to comment.