Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix syntax error in generated types #2597

Merged
merged 2 commits into from Jul 30, 2020
Merged

Fix syntax error in generated types #2597

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec70f49
fix(build): dist-custom-elements-bundle types
snaptopixel Jul 28, 2020
1511786
fix(build): dist-custom-elements-bundle types
snaptopixel Jul 28, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 9 additions & 8 deletions src/compiler/output-targets/dist-custom-elements-bundle/custom-elements-types.ts
View file
Open in desktop
Expand Up @@ -40,14 +40,15 @@ const generateCustomElementsTypesOutput = async (
`export declare const defineCustomElements: (opts?: any) => void;`,
``,
`/**`,
`* Used to manually set the base path where assets can be found.`,
`* If the script is used as "module", it's recommended to use "import.meta.url",`,
`* such as "setAssetPath(import.meta.url)". Other options include`,
`* "setAssetPath(document.currentScript.src)", or using a bundler's replace plugin to`,
`* dynamically set the path at build time, such as "setAssetPath(process.env.ASSET_PATH)".`,
`* But do note that this configuration depends on how your script is bundled, or lack of`,
`* bunding, and where your assets can be loaded from. Additionally custom bundling`,
`* will have to ensure the static assets are copied to its build directory.`,
` * Used to manually set the base path where assets can be found.`,
` * If the script is used as "module", it's recommended to use "import.meta.url",`,
` * such as "setAssetPath(import.meta.url)". Other options include`,
` * "setAssetPath(document.currentScript.src)", or using a bundler's replace plugin to`,
` * dynamically set the path at build time, such as "setAssetPath(process.env.ASSET_PATH)".`,
` * But do note that this configuration depends on how your script is bundled, or lack of`,
` * bunding, and where your assets can be loaded from. Additionally custom bundling`,
` * will have to ensure the static assets are copied to its build directory.`,
` */`,
`export declare const setAssetPath: (path: string) => void;`,
``,
];
Expand Down