Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs) Update CONTRIBUTING with npm pack #2940

Merged
merged 1 commit into from
Jun 25, 2021

Conversation

rwaskiewicz
Copy link
Member

@rwaskiewicz rwaskiewicz commented Jun 25, 2021

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe): Backport of fix(testing): puppeteer v10 support聽#2934

What is the current behavior?

We don't discuss testing with npm pack in CONTRIBUTING.md, and can potentially commit the created tarball to git 馃あ

What is the new behavior?

  • add lessons learned from using npm pack to the CONTRIBUTING.md doc
  • update .gitignore to ignote .tgz files

Does this introduce a breaking change?

  • Yes
  • No

Other information

  • I plan on squashing this branch when it's time to merge. I'll update the commit body at that time

- add lessons learned from using npm pack to the CONTRIBUTING.md doc
- update .gitignore to ignote .tgz files
@rwaskiewicz rwaskiewicz merged commit daa74b9 into master Jun 25, 2021
@rwaskiewicz rwaskiewicz deleted the rwaskiewicz/update-contributing branch June 25, 2021 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants