Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): fix unwanted resize on screenshot #3166

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ryuran
Copy link

@ryuran ryuran commented Dec 2, 2021

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Unit tests (npm test) were run locally and passed
  • E2E Tests (npm run test.karma.prod) were run locally and passed
  • Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Puppeteer do a resize while screenshot
If a component rerender on resize, the screenshot can happen during or before rendering.

GitHub Issue Number: #3145

What is the new behavior?

Puppeteer don't resize on screenshot

Does this introduce a breaking change?

  • Yes
  • No

Testing

@ryuran ryuran requested a review from a team December 2, 2021 15:08
@splitinfinities splitinfinities added the Resolution: Refine This PR is marked for Jira refinement. We're not working on it - we're talking it through. label Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: Refine This PR is marked for Jira refinement. We're not working on it - we're talking it through.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants