fix(compiler): support rollup's external input option

[awk]

Pluck the external option from the stencil config and pass it through to rollup.

Pull request checklist

Please check if your PR fulfills the following requirements:

• Tests for the changes have been added (for bug fixes / features)
• Docs have been reviewed and added / updated if needed (for bug fixes / features)
• Build (npm run build) was run locally and any changes were pushed
• Unit tests (npm test) were run locally and passed
• E2E Tests (npm run test.karma.prod) were run locally and passed
• Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

• Bugfix
• Feature
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Other (please describe):

What is the current behavior?

GitHub Issue Number: #3226

What is the new behavior?

The external option is now supported and works when added to the rollupConfig.inputOptions

Does this introduce a breaking change?

• Yes
• No

Testing

In my project (private - sorry) which has a complex set of module dependencies I can see that the desired module is no longer included in the stencil output.

Other information

[rwaskiewicz]

Thanks for this PR! I see the accompanying issue and have labeled this PR for the team to take a look at both a little more closely.

[awk]

@rwaskiewicz Do you have an update on the process for this PR ? Any outstanding questions or issues?

[rwaskiewicz]

@awk I think the next steps for this PR is for the team to sit down and review the PR. Specifically, we'll be looking at the changes and convincing ourselves that it doesn't conflict with any internal rollup configuration Stencil currently does. While I can't promise an exact timeline, we'll take a look as soon as we get a chance!

[rwaskiewicz]

In the mean time, I've enabled the rest of CI to run for this PR to make sure the rest of our checks pass

[TiagoVenceslau]

@rwaskiewicz Are there any updates on @awk 's PR? This would also be a very important feature for a project we're developing

[mikaelkaron]

This would be nice to include. The current workaround I'm using is based on this but with a slight modification:

  rollupPlugins: {
    before: [
      {
        name: 'overwrite-rollup-options',
        options: (options: RollupInputOptions) => ({
          ...options,
          external: ['@package/identifier']
        })
      }
    ]
  },