fix(puppeteer-page): add existing head content to page #3257
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Read the existing head element content, add that content to the e2e page that is being created. This prevents a user losing script or style tags that may have been added to the page before using the setContent method. Fixes #3229
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm test
) were run locally and passednpm run test.karma.prod
) were run locally and passednpm run prettier
) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Fixes the issue described in #3229
GitHub Issue Number: 3229
What is the new behavior?
Before creating the new e2e page, pull the content from the head element and add the content to the new page.
This prevents e2ePage.setContent from removing style and script tags added to the page before calling setContent.
Does this introduce a breaking change?
Testing
I manually linked the project into a Stencil project of my own. I used Puppeteer's
addScriptTag
method to add scripts to my e2ePage, then called thesetContent
method. Afterwards, I manually verified that the script tags were still present in my e2e page.