Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler): Prevent extTransformsPlugin from outputting collection dependency css #3306

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

George-Payne
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Unit tests (npm test) were run locally and passed
  • E2E Tests (npm run test.karma.prod) were run locally and passed
  • Prettier (npm run prettier) was run locally and passed

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

GitHub Issue Number: #3305

What is the new behavior?

extTransformsPlugin will no longer output collection dependency css when building collection files.

Does this introduce a breaking change?

  • Yes
  • No

Testing

Linked build of stencil to reproduction lib and rebuilt lib.

Other information

@George-Payne George-Payne requested a review from a team March 28, 2022 17:07
@George-Payne George-Payne force-pushed the prevent-ext-transforms-plugin-from-outputing-collection-dependency-css branch from 186d265 to efc58a7 Compare March 29, 2022 08:55
@George-Payne George-Payne changed the title Prevent extTransformsPlugin from outputting collection dependency css fix(compiler): Prevent extTransformsPlugin from outputting collection dependency css Mar 29, 2022
@mikaelkaron
Copy link

patch works here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants