fix(compiler): try to create web worker with the workerPath before falling back to blob #3513
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build
) was run locally and any changes were pushednpm test
) were run locally and passednpm run test.karma.prod
) were run locally and passednpm run prettier
) was run locally and passedPull request type
Please check the type of change your PR introduces:
What is the current behavior?
GitHub Issue Number: #3512
Currently the worker plugin creates the Web Worker by first creating a blob of a script which loads the actual script via
importScripts
. However the path to the script is calculated vianew URL(<file_name>, import.meta.url)
, which generates a relative path for some frameworks (as Nextjs mentioned in the issue). I would expect most SSR frameworks to do this to avoid mismatches between the server and client. TheimportScripts
method fails on loading a relative path however.What is the new behavior?
Before loading the worker in the current way, try to create it with the resolved script path directly. In case of error, fall back to the current implementation.
This is in line with src/compiler/sys/worker/web-worker-main.ts
Does this introduce a breaking change?
Testing
Clone the reproduction repo from the issue & apply this patch to stencil. The web worker should start now.
Other information