Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): remove need to compile scripts #5370

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

christian-bromann
Copy link
Member

What is the current behavior?

Currently a developer working on Stencil needs to compile the entire scripts folder first before running the files in them. This seems cumbersome and there is an opportunity to improve the DX here.

What is the new behavior?

By adding tsx we can get rid of the intermediate build step by running TS files on demand. This simplifies a lot of internal scripts and confusion when it comes to resolving paths.

Documentation

Does this introduce a breaking change?

  • Yes
  • No

Testing

Checkout the branch and run npm run build.

Other information

I time boxed this effort to ensure to get some opinion by the @ionic-team/stencil team first. Currently with the current patch there are two limitations:

  • since call the build script directly instead via the Rollup CLI we don't get all the build logs, while rollup support TS files it doesn't support importing them from the config - I think we can work around this but it needs a bit more investigations
  • since call the build script directly instead via the Rollup CLI we don't get the --watch flag to behave the same anymore - I think there is a work around for this too by using Nodemon or resolving the first limitation

Copy link
Contributor

github-actions bot commented Feb 15, 2024

PR built and packed!

Download the tarball here: https://github.com/ionic-team/stencil/actions/runs/7921262906/artifacts/1249120722

If your browser saves files to ~/Downloads you can install it like so:

npm install ~/Downloads/stencil-core-4.12.2.tgz

@tanner-reits tanner-reits removed their request for review May 2, 2024 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant