Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reactivity issue after user gets enough mana to cover the block cost #8529

Merged

Conversation

cpl121
Copy link
Member

@cpl121 cpl121 commented May 15, 2024

Closes #8505

Summary

Please summarize your changes, describing what they are and why they were made.

...

Changelog

- Please write a list of changes

Testing

Platforms

Please select any platforms where your changes have been tested.

  • Desktop
    • MacOS
    • Linux
    • Windows

Instructions

Please describe the specific instructions, configurations, and/or test cases necessary to test and verify that your changes work as intended.

...

Checklist

Please tick the following boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or modified tests that prove my changes work as intended
  • I have verified that new and existing unit tests pass locally with my changes
  • I have verified that my latest changes pass CI workflows for testing and linting
  • I have made corresponding changes to the documentation

@cpl121 cpl121 marked this pull request as ready for review May 16, 2024 09:11
@@ -57,6 +58,9 @@
secondsRemainingCountdownInterval = setInterval(() => {
secondsRemaining -= 1
if (secondsRemaining <= 0) {
refreshTransactionInfo().then(() => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be good fixing these linter warnings 🙏🏼

@begonaalvarezd begonaalvarezd merged commit 943ab67 into canary May 20, 2024
4 checks passed
@begonaalvarezd begonaalvarezd deleted the fix/reactivity-issue-after-user-gets-enough-mana branch May 20, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Fix reactivity issue after user gets enough mana to cover the block cost
2 participants