Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify tabs configuration #1034

Merged
merged 7 commits into from Jul 11, 2023
Merged

Unify tabs configuration #1034

merged 7 commits into from Jul 11, 2023

Conversation

jlvandenhout
Copy link
Collaborator

@jlvandenhout jlvandenhout commented Jul 11, 2023

Description of change

This unifies the tab configuration and adds the queryString boolean to make them linkable. i.e.:

<Tabs groupId="..." queryString>
  <TabItem value="..." label="...">
    ...
  </TabItem>
  ...
</Tabs>

The first tab is shown by default, unless <groupID>=<value> is added as query to the URL.

Links to any relevant issues

fixes #1032

Type of change

  • Enhancement (a non-breaking change which adds functionality)

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own changes
  • I have made sure that added/changed links still work

@jlvandenhout jlvandenhout changed the title Fix/unify tabs Unify tabs configuration Jul 11, 2023
@Dr-Electron
Copy link
Collaborator

/create-preview

@github-actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit:

✅ Preview: https://iota-wiki-d7vxy12k5-iota1.vercel.app

@Dr-Electron
Copy link
Collaborator

There seems to be a problem with the preview.
So we will merge and figure out if it work on main

@Dr-Electron Dr-Electron merged commit 8b0f0a3 into main Jul 11, 2023
11 checks passed
@Dr-Electron Dr-Electron deleted the fix/unify-tabs branch July 11, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make tabs linkable
2 participants