-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of filters in custom search modal. #1560
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Vivek Jain <vkj.vivekkumarjain@gmail.com>
Signed-off-by: Vivek Jain <vkj.vivekkumarjain@gmail.com>
Signed-off-by: Vivek Jain <vkj.vivekkumarjain@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems horrible to maintain. Can't we import this from configs or something similar?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think while updating the filter with instantSearch we can get rid of this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to touch this file?
And please don't remove the commend at the top. It helps us keep track of swizzled versions of Docusaurus components
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was needed to add few styles in the footer since while styling and alinging the filter, footer's position was getting disturbed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did this get removed?
Just as a consideration, since we already have to change the search component provided by |
Description of change
Links to any relevant issues
fixes #1531
Type of change
Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.